vmnet: Move download-only check to start command

[nirs]

Skipping validation in vment.ValidateHelper() was the simplest way to avoid validation when starting with --download-only flag, but it requires accessing viper outside of the commands using strings. This make the code fragile and makes testing harder since we depend on global state.

Fixed by moving vment-helper validation to validateVmnetNetwork() helper in the minikube/cmd package. We skip the call to vment.ValidateHelper() in download-only mode. The helper is called for vfkit and krunkit when validating the --network flag.

For krunkit the validation was part of Driver.Status check, which is good place to validate, but it does not have access to start command flags. Validating in the start command is little bit ugly since krunkit does not use the --network option, and it moves driver logic to the start command, but at least it is consistent with vfkit and qemu, and it avoids the trouble of passing start flags deep inside minikube.

Part-of #21670

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nirs
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nirs]

/ok-to-test

[k8s-ci-robot]

@nirs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-minikube-integration	7a78923	link	true	/test pull-minikube-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[nirs]

Replaced by #21683

[minikube-pr-bot]

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21682 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 44.7s    │ 44.8s                  │
│ enable ingress │ 17.3s    │ 17.1s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 45.7s 44.5s 46.6s 44.0s 42.6s
Times for minikube (PR 21682) start: 43.5s 45.0s 46.0s 43.1s 46.5s

Times for minikube ingress: 17.4s 15.9s 15.8s 20.3s 16.9s
Times for minikube (PR 21682) ingress: 20.9s 15.9s 16.4s 15.8s 16.4s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21682 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.0s    │ 22.5s                  │
│ enable ingress │ 11.4s    │ 11.0s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 10.6s 10.6s 10.6s 11.6s 13.6s
Times for minikube (PR 21682) ingress: 10.6s 10.6s 10.6s 12.6s 10.6s

Times for minikube (PR 21682) start: 22.0s 22.2s 25.0s 20.4s 22.9s
Times for minikube start: 26.0s 22.4s 23.1s 22.1s 21.3s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21682 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.4s    │ 20.8s                  │
│ enable ingress │ 20.3s    │ 20.7s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 22.2s 20.4s 20.2s 19.6s 19.3s
Times for minikube (PR 21682) start: 21.2s 22.2s 20.7s 19.8s 20.3s

Times for minikube (PR 21682) ingress: 21.1s 22.1s 20.2s 20.1s 20.1s
Times for minikube ingress: 20.1s 20.1s 21.1s 20.1s 20.1s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Linux_containerd (2 failed)	TestMultiNode/serial/AddNode(gopogh)	0.00% (chart)
Docker_Linux_containerd (2 failed)	TestMultiNode/serial/MultiNodeLabels(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (8 failed)	TestAddons/serial/Volcano(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (8 failed)	TestAddons/parallel/Ingress(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (8 failed)	TestAddons/parallel/CSI(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (8 failed)	TestAddons/parallel/LocalPath(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (8 failed)	TestFunctional/parallel/DashboardCmd(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (8 failed)	TestFunctional/parallel/PersistentVolumeClaim(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (8 failed)	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (8 failed)	TestFunctional/parallel/TunnelCmd/serial/AccessDirect(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestDockerEnvContainerd(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestFunctional/parallel/DashboardCmd(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestFunctional/parallel/ServiceCmdConnect(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestFunctional/parallel/PersistentVolumeClaim(gopogh)	0.00% (chart)
KVM_Linux_crio (4 failed)	TestFunctional/parallel/ImageCommands/ImageListShort(gopogh)	2.50% (chart)

Besides the following environments also have failed tests:

• Docker_Linux_crio: 56 failed (gopogh)

• Docker_Linux_crio_arm64: 38 failed (gopogh)

To see the flake rates of all tests by environment, click here.