-
Notifications
You must be signed in to change notification settings - Fork 5.1k
github actions: try macos15-intel #21677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@medyagh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash to single commit, there is no reason to split the commits for this change.
driver: vfkit | ||
cruntime: docker | ||
os: macos-13 | ||
os: macos-13-intel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos-15-intel
- name: Ensure bootpd is enabled (macos-13) | ||
if: matrix.os == 'macos-13' | ||
- name: Ensure bootpd is enabled (macos) | ||
if: contains(matrix.os, 'macos') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed on macos-15, time to remove this hack.
HOMEBREW=$(which brew) && sudo ${HOMEBREW} services start socket_vmnet | ||
- name: Install vfkit and vmnet_helper (macos) | ||
if: matrix.os == 'macos-13' && matrix.driver == 'vfkit' | ||
if: contains(matrix.os, 'macos') && matrix.driver == 'vfkit' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simplify to check only for vfkit since it is not available on !macOS
run: brew install tree | ||
- name: Install vfkit and vmnet-helper (macos) | ||
if: matrix.driver == 'vfkit' | ||
if: contains(matrix.os, 'macos') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorect change - keep the previous code.
No description provided.