Move linux/darwin binaries into cache/binaries folder (#21179)

[henry3260]

This PR addresses issue #21179 by reorganizing the cache folder structure for binaries.

Before

• Binaries for Linux and Darwin were placed directly under:
  • ~/.minikube/cache/linux
  • ~/.minikube/cache/darwin

After

• They are now moved into a dedicated binaries subfolder:
  • ~/.minikube/cache/binaries/linux
  • ~/.minikube/cache/binaries/darwin

Why

• This improves organization of the cache directory.
• Aligns binaries with how other cached items (e.g., images, ISO files) are stored.
• No functional behavior is changed, only the storage path for binaries.

Fixes #21179

Screenshot (Before)

Screenshot (After)

[k8s-ci-robot]

Hi @henry3260. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[nirs]

I think we should use "bin", it is more consistent with ~/.minikube/bin and the rest of the world.

We are using "binaries" internally which would nice to change also to bin but it may be harder since we may code using it. Since this cache directory is new we don't have backward compatibility concerns.

[henry3260]

I think we should use "bin", it is more consistent with ~/.minikube/bin and the rest of the world.

We are using "binaries" internally which would nice to change also to bin but it may be harder since we may code using it. Since this cache directory is new we don't have backward compatibility concerns.

Thanks for the suggestion! That makes sense, I’ll update it to use bin for consistency.

[nirs]

/lgtm

[nirs]

/assign @medyagh

[nirs]

~/.minikube is the default, but if MINIKUBE_HOME is defined it will be used. There is a helper function to return the right path (but I don't remember the function name). Check what other tests are doing.

[nirs]

Looks good, to make it even better squash this commit into the first one. Having this in git history is not helpful.

[nirs]

/lgtm

[nirs]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henry3260, nirs
Once this PR has been reviewed and has the lgtm label, please ask for approval from medyagh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@henry3260: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-minikube-integration	fca5789	link	true	/test pull-minikube-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.