Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions cmd/minikube/cmd/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing *
klog.Errorf("Error autoSetOptions : %v", err)
}

virtualBoxMacOS13PlusWarning(driverName)
virtualBoxDeprecationWarning(driverName)
hyperkitDeprecationWarning(driverName)
validateFlags(cmd, driverName)
validateUser(driverName)
Expand Down Expand Up @@ -402,16 +402,13 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing *
}, nil
}

func virtualBoxMacOS13PlusWarning(driverName string) {
if !driver.IsVirtualBox(driverName) || !detect.MacOS13Plus() {
// virtualBoxDeprecationWarning prints a deprecation warning for the virtualbox driver
func virtualBoxDeprecationWarning(driverName string) {
if !driver.IsVirtualBox(driverName) {
return
}
out.WarningT(`Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'.
https://minikube.sigs.k8s.io/docs/drivers/vfkit/
https://minikube.sigs.k8s.io/docs/drivers/qemu/
https://minikube.sigs.k8s.io/docs/drivers/docker/
For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274
`)
out.WarningT(`The 'virtualbox' driver is deprecated and will be removed in a future release.
You can use alternative drivers: {{.drivers}}.`, out.V{"drivers": strings.Join(driver.SupportedDrivers(), ", ")})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this? please keep the links to the docs. This make it very easy to find more info by clicking on the link in the shell, and it is not required for this change.

}

// hyperkitDeprecationWarning prints a deprecation warning for the hyperkit driver
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/registry/drvs/virtualbox/virtualbox.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func init() {
Config: configure,
Status: status,
Default: true,
Priority: registry.Fallback,
Priority: registry.Deprecated,
Init: func() drivers.Driver { return virtualbox.NewDriver("", "") },
})
if err != nil {
Expand Down
Loading