Skip to content

Conversation

henry3260
Copy link

Why are we solving this issue?

Currently, when selecting a driver in the image template, vfkit and krunkit are not available as options.
This update ensures that users can also select these drivers, which are already supported in minikube, improving completeness and user experience.

To address this issue, are there any code changes?

Yes.
I updated the .github/ISSUE_TEMPLATE files to include vfkit and krunkit in the driver selection list.
No functional code changes are required since the drivers are already supported; this PR only updates the templates to reflect that.

What places can the assignee treat as reference points?

  • .github/ISSUE_TEMPLATE/ folder (issue templates definitions)
  • Existing driver options already listed (e.g., docker, podman, etc.)

How can the assignee reach out to you for help?

Feel free to tag me in the PR discussion (@henry0512) or comment directly in issue #21604.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @henry3260. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like to add the same option for other languages too ?

@medyagh medyagh changed the title Add vfkit and krunkit options in ISSUE_TEMPLATE (#21604) docs: Add vfkit and krunkit options in ISSUE_TEMPLATE (#21604) Sep 22, 2025
@nirs
Copy link
Contributor

nirs commented Sep 22, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

@henry3260: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-integration c767fe5 link true /test pull-minikube-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@henry3260
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

@henry3260: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to squash the commits since this is the same change applied to all templates that have a driver list.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henry3260, nirs
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nirs
Copy link
Contributor

nirs commented Sep 23, 2025

@henry3260 there is no need to run tests for this change. This is affects only GitHub templates.

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2025
@nirs
Copy link
Contributor

nirs commented Sep 23, 2025

@henry3260 thanks!
@medyagh merge?

@nirs
Copy link
Contributor

nirs commented Oct 2, 2025

/assign @medyagh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants