-
Notifications
You must be signed in to change notification settings - Fork 5.1k
docs: Add vfkit and krunkit options in ISSUE_TEMPLATE (#21604) #21611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @henry3260. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you like to add the same option for other languages too ?
/lgtm |
@henry3260: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
@henry3260: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to squash the commits since this is the same change applied to all templates that have a driver list.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henry3260, nirs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@henry3260 there is no need to run tests for this change. This is affects only GitHub templates. |
c767fe5
to
475fa3a
Compare
New changes are detected. LGTM label has been removed. |
267f7ba
to
05b680b
Compare
@henry3260 thanks! |
/assign @medyagh |
Why are we solving this issue?
Currently, when selecting a driver in the image template,
vfkit
andkrunkit
are not available as options.This update ensures that users can also select these drivers, which are already supported in minikube, improving completeness and user experience.
To address this issue, are there any code changes?
Yes.
I updated the
.github/ISSUE_TEMPLATE
files to includevfkit
andkrunkit
in the driver selection list.No functional code changes are required since the drivers are already supported; this PR only updates the templates to reflect that.
What places can the assignee treat as reference points?
.github/ISSUE_TEMPLATE/
folder (issue templates definitions)docker
,podman
, etc.)How can the assignee reach out to you for help?
Feel free to tag me in the PR discussion (
@henry0512
) or comment directly in issue #21604.