Skip to content

Conversation

@neolit123
Copy link
Member

@neolit123 neolit123 commented Dec 3, 2025

@neolit123 neolit123 added this to the v1.35 milestone Dec 3, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kinder Issues to track work in the kinder tool labels Dec 3, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2025
@neolit123
Copy link
Member Author

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2025
@neolit123 neolit123 mentioned this pull request Dec 3, 2025
6 tasks
Copy link
Contributor

@HirazawaUi HirazawaUi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HirazawaUi,neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123 neolit123 requested a review from Copilot December 4, 2025 17:02
Copilot finished reviewing on behalf of neolit123 December 4, 2025 17:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the kinder workflows to support Kubernetes 1.35 by bumping the default version and removing outdated workflow configurations for version 1.31, which is now outside the supported version skew of 3.

  • Updates default Kubernetes version from v1.34.0 to v1.35.0 in the workflow update script
  • Removes workflow files for Kubernetes 1.31 (now outside the 3-version skew window)
  • Updates ginkgo test skip patterns to account for versions 1.35 and 1.36

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
kinder/hack/update-workflows.sh Updates default Kubernetes version to v1.35.0
kinder/ci/workflows/upgrade-1.34-latest.yaml Removes upgrade workflow from 1.34 to latest (deleted)
kinder/ci/workflows/upgrade-1.31-1.32.yaml Removes outdated 1.31 to 1.32 upgrade workflow (deleted)
kinder/ci/workflows/skew-latest-on-1.34.yaml Removes skew test for latest on 1.34 (deleted)
kinder/ci/workflows/skew-kubelet-1.34-on-latest.yaml Updates ginkgo skip pattern to include versions 1.35 and 1.36
kinder/ci/workflows/skew-kubelet-1.33-on-latest.yaml Updates ginkgo skip pattern to include version 1.36
kinder/ci/workflows/skew-kubelet-1.32-on-latest.yaml Removes skew test for 1.32 kubelet on latest (deleted)
kinder/ci/workflows/skew-kubelet-1.31-on-1.34.yaml Removes outdated skew test for 1.31 on 1.34 (deleted)
kinder/ci/workflows/skew-kubelet-1.31-on-1.33.yaml Removes outdated skew test for 1.31 on 1.33 (deleted)
kinder/ci/workflows/skew-kubelet-1.31-on-1.32.yaml Removes outdated skew test for 1.31 on 1.32 (deleted)
kinder/ci/workflows/skew-1.32-on-1.31.yaml Removes outdated skew test for 1.32 on 1.31 (deleted)
kinder/ci/workflows/regular-1.31.yaml Removes regular workflow for 1.31 (deleted)
kinder/ci/workflows/external-etcd-1.31.yaml Removes external etcd workflow for 1.31 (deleted)
kinder/ci/workflows/external-ca-1.31.yaml Removes external CA workflow for 1.31 (deleted)
kinder/ci/workflows/dryrun-1.34.yaml Updates upgrade version from ci/latest to ci/latest-1.35
kinder/ci/workflows/dryrun-1.31.yaml Removes dryrun workflow for 1.31 (deleted)
kinder/ci/workflows/discovery-1.31.yaml Removes discovery workflow for 1.31 (deleted)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@neolit123
Copy link
Member Author

checking the copilot analysis it found that i forgot to git add the new 1.35 workflows.

Copilot finished reviewing on behalf of neolit123 December 4, 2025 17:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neolit123
Copy link
Member Author

You are eligible to use GitHub Copilot for free.

i seem to have free access to it by click the 🛞 icon next to the reviewers. but that doesn't work for k/k.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants