-
Notifications
You must be signed in to change notification settings - Fork 735
kinder: update workflows for 1.35 #3264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
HirazawaUi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HirazawaUi, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the kinder workflows to support Kubernetes 1.35 by bumping the default version and removing outdated workflow configurations for version 1.31, which is now outside the supported version skew of 3.
- Updates default Kubernetes version from v1.34.0 to v1.35.0 in the workflow update script
- Removes workflow files for Kubernetes 1.31 (now outside the 3-version skew window)
- Updates ginkgo test skip patterns to account for versions 1.35 and 1.36
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kinder/hack/update-workflows.sh | Updates default Kubernetes version to v1.35.0 |
| kinder/ci/workflows/upgrade-1.34-latest.yaml | Removes upgrade workflow from 1.34 to latest (deleted) |
| kinder/ci/workflows/upgrade-1.31-1.32.yaml | Removes outdated 1.31 to 1.32 upgrade workflow (deleted) |
| kinder/ci/workflows/skew-latest-on-1.34.yaml | Removes skew test for latest on 1.34 (deleted) |
| kinder/ci/workflows/skew-kubelet-1.34-on-latest.yaml | Updates ginkgo skip pattern to include versions 1.35 and 1.36 |
| kinder/ci/workflows/skew-kubelet-1.33-on-latest.yaml | Updates ginkgo skip pattern to include version 1.36 |
| kinder/ci/workflows/skew-kubelet-1.32-on-latest.yaml | Removes skew test for 1.32 kubelet on latest (deleted) |
| kinder/ci/workflows/skew-kubelet-1.31-on-1.34.yaml | Removes outdated skew test for 1.31 on 1.34 (deleted) |
| kinder/ci/workflows/skew-kubelet-1.31-on-1.33.yaml | Removes outdated skew test for 1.31 on 1.33 (deleted) |
| kinder/ci/workflows/skew-kubelet-1.31-on-1.32.yaml | Removes outdated skew test for 1.31 on 1.32 (deleted) |
| kinder/ci/workflows/skew-1.32-on-1.31.yaml | Removes outdated skew test for 1.32 on 1.31 (deleted) |
| kinder/ci/workflows/regular-1.31.yaml | Removes regular workflow for 1.31 (deleted) |
| kinder/ci/workflows/external-etcd-1.31.yaml | Removes external etcd workflow for 1.31 (deleted) |
| kinder/ci/workflows/external-ca-1.31.yaml | Removes external CA workflow for 1.31 (deleted) |
| kinder/ci/workflows/dryrun-1.34.yaml | Updates upgrade version from ci/latest to ci/latest-1.35 |
| kinder/ci/workflows/dryrun-1.31.yaml | Removes dryrun workflow for 1.31 (deleted) |
| kinder/ci/workflows/discovery-1.31.yaml | Removes discovery workflow for 1.31 (deleted) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1335059 to
2469b92
Compare
|
New changes are detected. LGTM label has been removed. |
|
checking the copilot analysis it found that i forgot to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
i seem to have free access to it by click the 🛞 icon next to the reviewers. but that doesn't work for k/k. |
Uh oh!
There was an error while loading. Please reload this page.