-
Notifications
You must be signed in to change notification settings - Fork 947
groups: change MessageModerationLevel of sig-cloud-provider-ibm-ppc64le-alerts #8808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…le-alerts Signed-off-by: Prajyot-Parab <[email protected]>
mkumatag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mkumatag @Prajyot-Parab Why do we want to change this to moderate none? Does that not open the group up to more risk of spam? |
The idea behind changing it to moderate: none is to avoid unnecessary manual approvals for every alert. That said, I understand the concern about increasing the risk of spam. Is there a better alternative that would let alerts go through automatically while still keeping some level of protection in place? I'm open to suggestions if there's a middle ground. |
|
@JoelSpeed Can we get this one approved and merged for now? We have incoming alerts that aren’t being propagated due to the explicit-approval requirement. In the meantime, I’ll actively look into possible alternatives. |
MODERATE_NONE