-
Notifications
You must be signed in to change notification settings - Fork 4.7k
AI starter kit chart #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
AI starter kit chart #579
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: volatilemolotov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Here is the initial PR, currently in draft state. Think we should be able to send it for reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want Cloud Build and Terraform as prerequisites. Suggest making this example more generic, like other AI examples. I'd like to focus on the Kubernetes manifests and make it customizable for different platforms.
Removed the example values and ci folder. Hope makefile can stay, it can be useful |
--mount --mount-string="/tmp/models-cache:/tmp/models-cache" | ||
``` | ||
|
||
2. **Install the chart:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to clarify the path this command should be run within
|
||
2. **Install the chart:** | ||
```bash | ||
helm install ai-starter-kit . \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like helm dependency build
is needed before install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Added
|
||
1. **Start minikube with persistent storage:** | ||
```bash | ||
minikube start --cpus 4 --memory 15000 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a step to create the models-cache
folder? mkdir -p /tmp/models-cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Also decided to move to $HOME due to some linux distributions mount /tmp as tmpfs which is i think half of size of RAM
@@ -0,0 +1,104 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is purpose of this notebook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just demonstrates that it can use preloaded model in memory. Just a sanity check if the both preload and jupyterhub work
@@ -0,0 +1,798 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the "outputs" blob in this file
-f values.yaml | ||
``` | ||
|
||
3. **Access JupyterHub:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which notebooks are runnable in the minikube environment? I assume the only one works is chat_bot? Can we add description in each notebook to detail in what environment it's runnable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check out which exactly can be run in Minikube and note accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All should work. Multi agent ray one needs ray enabled but we are not enabling it by default
helm install ai-starter-kit . \ | ||
--set huggingface.token="YOUR_HF_TOKEN" \ | ||
-f values.yaml \ | ||
-f values-gke.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janetkuo do you have concern to include the GKE specific setup in the example? Do you think we should remove this all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the example should be as generic as possible so that it's applicable to most Kubernetes clusters. It might be challenging at times for some platform-specific setup, and in that case we should call it out and mention alternatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our case, there are some platform specific setup such as specify the GPU in GKE cloud.google.com/gke-accelerator: nvidia-l4
. What is your suggestion to handle this?
helm install ai-starter-kit . \ | ||
--set huggingface.token="YOUR_HF_TOKEN" \ | ||
-f values.yaml \ | ||
-f values-gke.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all the helm install
on GKE autopilot instructions here I got error admission webhook "warden-validating.common-webhooks.networking.gke.io" denied the request: GKE Warden rejected the request because it violates one or more constraints. Violations details: {"[denied by autopilot-persistent-volume-limitation]":["Persistent Volume sources can only be of types [csi nfs gcePersistentDisk] within Autopilot."]}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill check what is going on with GKE setup. Lets see if it even should be here
This PR adds a AI starter kit helm chart that aims to provide a out of the box development solution for AI workloads. Uses RayServe, Ollama or Ramalama to run the LLMs and JupyterHub for the development.