Revert httpcache integration #75
Conversation
The httpcache transport is breaking authentication where no fix seems to be implemented yet. I'd propose to revert the change for now to be able to use authenticated requests in tools like `k/release/cmd/release-notes`. Refers to: google/go-github#1503, gregjones/httpcache#104 Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
sig/release
k8s-ci-robot
added
approved
|
@cpanato PTAL, I think we also require a new release after this PR got merged. |
|
will we get this back when the issue in upstream is fixed? |
Yes, but since the PR is open for a long time and the project overall seems to have got no modifications in the last couple of years I doubt that it will get merged soon. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
@saschagrunert i will run the release, sounds good? |
Awesome, thank you! |
3 participants
What type of PR is this?
/kind bug
What this PR does / why we need it:
The httpcache transport is breaking authentication where no fix seems to
be implemented yet. I'd propose to revert the change for now to be able
to use authenticated requests in tools like
k/release/cmd/release-notes.Refers to: google/go-github#1503, gregjones/httpcache#104
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Reverts #58
Does this PR introduce a user-facing change?