rename Helm chart from nrr-controller to node-readiness-controller - #407
Merged
kubernetes-prow[bot] merged 1 commit intoAug 14, 2026
Conversation
✅ Deploy Preview for node-readiness-controller canceled.
|
kubernetes-prow
Bot
added
cncf-cla: yes
Priyankasaggu11929
force-pushed
the
setup-helm-chart-staging-publish
branch
from
August 14, 2026 09:28
1ee88e3 to
6da2d50
Compare
ajaysundark
reviewed
Aug 14, 2026
| git clone https://github.com/kubernetes-sigs/node-readiness-controller.git | ||
| cd node-readiness-controller | ||
| helm install my-release --namespace nrr-system --create-namespace ./charts/nrr-controller | ||
| helm install my-release --namespace nrr-system --create-namespace ./charts/node-readiness-controller |
Contributor
There was a problem hiding this comment.
@Priyankasaggu11929 does this need to be created again?
Member
Author
There was a problem hiding this comment.
kubernetes-prow
Bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark, Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
2 tasks
tejassinghbhati
added a commit
to tejassinghbhati/node-readiness-controller
that referenced
this pull request
Aug 14, 2026
The chart directory and name became node-readiness-controller in kubernetes-sigs#407, so the install, upgrade and uninstall commands in the Helm section needed updating along with the path to the bundled CRD. Also fixes the selector in Verification. It looked for component=node-readiness-controller, and nothing sets a component label, not the chart and not the kustomize manifests, so the command matched no pods on either path. Both set control-plane=controller-manager, so use that. A reader following the new Helm section lands on those commands straight after installing. Signed-off-by: tejassinghbhati <tejassinghbhati077@gmail.com>
This was referenced Aug 14, 2026
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up on #402 (comment)
purely a rename of
nrr-controllertonode-readiness-controller, no logic changesChecklist
make testpassesmake lintpasses/assign @ajaysundark