Skip to content

Conversation

ellistarn
Copy link
Contributor

Modules don't land in goproxy until they are depended on by another package and pulled through the proxy. Some corporate firewalls (...) synchronize from go proxy, and until packages are hydrated there, they cannot be reflected into internal build systems. This change automates that pull and makes sure the proxy always has the latest version.

See: https://github.com/awslabs/operatorpkg/blob/main/.github/workflows/postsubmit.yaml

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ellistarn
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 3, 2025
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally not opposed to this but we did want to migrate to kubernetes job infrastructure so any github action we add here we probably want to migrate off. its not a big deal here but I still think we should get another opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants