-
Notifications
You must be signed in to change notification settings - Fork 195
training_server: Fix UnboundLocalError in TTFT model training #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: slo-prediction-experimental
Are you sure you want to change the base?
training_server: Fix UnboundLocalError in TTFT model training #1843
Conversation
Error: UnboundLocalError: cannot access local variable 'ttft_feature_cols_tree' where it is not associated with a value at training_server.py:640 Cause: Variables defined inside if len(df_ttft) >= MIN_SAMPLES_FOR_RETRAIN block but referenced outside it due to incorrect indentation. Fix: Indented TTFT training code block to match TPOT section structure.
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RishabhSaini The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @RishabhSaini. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/lgtm |
Error: UnboundLocalError: cannot access local variable 'ttft_feature_cols_tree' where it is not associated with a value at training_server.py:640
Cause: Variables defined inside if len(df_ttft) >= MIN_SAMPLES_FOR_RETRAIN block but referenced outside it due to incorrect indentation.
Fix: Indented TTFT training code block to match TPOT section structure.