fix(civo): normalize @ apex record names - #6674
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @linusfr! |
|
Hi @linusfr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ivankatliarchuk This refreshes #6184 with requested helper extraction and A/AAAA-only normalization. |
What does it do ?
Normalizes Civo's
"@"apex marker to ExternalDNS's empty-name convention for A and AAAA records. This lets apex records resolve and match asexample.cominstead of@.example.com.Motivation
Civo returns
"@"for apex address records. Without normalization, reconciliation cannot match existing apex records and repeatedly attempts to recreate them.This reopens the stale #6184 from @cjohnhanson. It incorporates @ivankatliarchuk's feedback: normalization is extracted into a helper and restricted to A/AAAA records. Create/update responses are not used; matching occurs against listed records before changes are submitted.
More
Verified: go test -race ./provider/civo passes.