Skip to content

fix(civo): normalize @ apex record names - #6674

Open
linusfr wants to merge 1 commit into
kubernetes-sigs:masterfrom
linusfr:fix/civo-apex-record-matching
Open

fix(civo): normalize @ apex record names#6674
linusfr wants to merge 1 commit into
kubernetes-sigs:masterfrom
linusfr:fix/civo-apex-record-matching

Conversation

@linusfr

@linusfr linusfr commented Aug 29, 2026

Copy link
Copy Markdown

What does it do ?

Normalizes Civo's "@" apex marker to ExternalDNS's empty-name convention for A and AAAA records. This lets apex records resolve and match as example.com instead of @.example.com.

Motivation

Civo returns "@" for apex address records. Without normalization, reconciliation cannot match existing apex records and repeatedly attempts to recreate them.

This reopens the stale #6184 from @cjohnhanson. It incorporates @ivankatliarchuk's feedback: normalization is extracted into a helper and restricted to A/AAAA records. Create/update responses are not used; matching occurs against listed records before changes are submitted.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Verified: go test -race ./provider/civo passes.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the provider Issues or PRs related to a provider label Aug 29, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 29, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: linusfr / name: Linus Frotscher (e79858c)

@kubernetes-prow

Copy link
Copy Markdown

Welcome @linusfr!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 29, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @linusfr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 29, 2026
@linusfr

linusfr commented Aug 29, 2026

Copy link
Copy Markdown
Author

@ivankatliarchuk This refreshes #6184 with requested helper extraction and A/AAAA-only normalization. go test -race ./provider/civo passes. Could you please review and, if appropriate, run /ok-to-test?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. provider Issues or PRs related to a provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant