Skip to content

Conversation

@Ganiredi
Copy link
Contributor

@Ganiredi Ganiredi commented Aug 28, 2025

Update go dependencies with 1.34.0 and resolved mustEmbedUnimplementedKeyManagementServiceServer method for forward compatibility

https://github.com/kubernetes/kubernetes/pull/132833/files

k8s.io/kms was migrated from gogo/protobuf to protoc-gen-go-grpc
gogo/protobuf (the old generator) didn't enforce the embedding requirement
protoc-gen-go-grpc (the new standard generator) enforces the
UnimplementedXXXServer embedding pattern : kubernetes/kubernetes#132833 , This change was merged to 1.34 onwards, More context here, The reason for this change as 132833 pull as a part of kubernetes/kubernetes#96564

  • //nolint:staticcheck is required to suppress the linting errors due to deprecated methods from v1beta API

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ganiredi
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @Ganiredi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2025
@notSoWiseOldMan
Copy link

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@notSoWiseOldMan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@notSoWiseOldMan
Copy link

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@notSoWiseOldMan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kmala
Copy link
Contributor

kmala commented Aug 29, 2025

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025
@Ganiredi
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Ganiredi
Copy link
Contributor Author

Ganiredi commented Sep 2, 2025

@yue9944882 Could you please help here to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants