-
Notifications
You must be signed in to change notification settings - Fork 91
Update go dependencies with 1.34.0 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ganiredi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Ganiredi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@notSoWiseOldMan: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@notSoWiseOldMan: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
|
New changes are detected. LGTM label has been removed. |
|
@yue9944882 Could you please help here to merge this PR? |
Update go dependencies with 1.34.0 and resolved
mustEmbedUnimplementedKeyManagementServiceServer method for forward compatibilityhttps://github.com/kubernetes/kubernetes/pull/132833/files
• k8s.io/kms was migrated from gogo/protobuf to protoc-gen-go-grpc
• gogo/protobuf (the old generator) didn't enforce the embedding requirement
• protoc-gen-go-grpc (the new standard generator) enforces the
UnimplementedXXXServer embedding pattern : kubernetes/kubernetes#132833 , This change was merged to 1.34 onwards, More context here, The reason for this change as
132833pull as a part of kubernetes/kubernetes#96564//nolint:staticcheckis required to suppress the linting errors due to deprecated methods from v1beta API