feat(hub): add upload-artifact utility#514
Open
myesmin wants to merge 1 commit into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
Add standalone S3/OCI upload helper and types so artifacts can be uploaded without coupling to the model registry client. Signed-off-by: myesmin <myesmin415@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
myesmin
force-pushed
the
feat/issue-475-upload-artifact-utility
branch
from
331f03c to
8da6368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a decoupled
upload_artifactutility for uploading model artifacts to S3 or OCI without registering them in a model registry, as described in #475.kubeflow/hub/storage.pywithupload_artifactand standalone S3 upload helperS3UploadParamsandOCIUploadParamsPydantic types inkubeflow/hub/types/kubeflow/hub/storage_test.pykubeflow.hubFixes #475
Test plan
uv run pytest -q kubeflow/hub/storage_test.pyuv run ruff check/ pre-commit on changed hub files