ci(pvc): upgrade Go to 1.24 for pvcviewer-controller

[henschwartz]

[TASK] Upgrade Go to 1.24 - pvcviewer-controller component #723

• Update CI workflow pvcviewer_controller_unit_test.yaml to use go-version 1.24
• Update go.mod to go 1.24
• Update Dockerfile GOLANG_VERSION to 1.24

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[henschwartz]

PVCViewer Controller Integration Test:

PVCViewer Contoller Multi-Arch Build Test:

Run PVCViewer Controller unit tests:

PVCViewer Controller Docker Publish:

[liavweiss]

Thanks Hen,

I reviewed the code and was able to deploy the component and create a volume. I also verified that there are no changes to go.sum.

One small comment: please add ci: to your PR title so it passes the Semantic PRs / Validate Title check.

/lgtm

[liavweiss]

Hey @henschwartz, following my earlier review, I noticed one more thing that could be improved. It’s not mandatory, but it would make the code cleaner.

notebooks/components/pvcviewer-controller/Dockerfile

Line 19 in 77c656d

RUN CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -mod=mod -o manager main.go

I checked our environment and the module cache is writable, so -mod=mod doesn’t add anything in Go 1.20+.
GO111MODULE=on is also deprecated and has no effect since modules are always enabled now.

We can remove these flags, though it’s not required for the PR approval.

[andyatmiami]

Hey @henschwartz - thanks for this contribution 💯

While I have tested the code in my own Kind cluster and feel confident about the changes - I'm hoping we can use this PR (opportunity) to improve the flexibility of the unit test configuration to make it less redundant .

If you can code and verify the simple suggestion I provide below - I will feel good about lgtming the PR quickly afterwards.

[andyatmiami]

Suggested change

	go-version: "1.24"
	go-version-file: 'components/pvcviewer-controller/go.mod'

Given we already need to adjust this code block - I think we would be better served to change it more substantially to avoid having to hardcode (and couple) this go-version input with the related go.mod file

You can see this pattern employed in notebooks-v2 code - and I think we should have notebooks-v1 follow suit! Will make any future updates easier - as we only need to modify go.mod and the GH workflow will then automatically pick up the right version.

• https://github.com/kubeflow/notebooks/blob/notebooks-v2/.github/workflows/ws-backend-test.yml#L31
  • note: for now lets NOT include the cache related key here - even though it is present in notebooks-v2

[andyatmiami]

/ok-to-test