-
Notifications
You must be signed in to change notification settings - Fork 69
feat: add ambient mode support to kubeflow controllers #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: notebooks-v1
Are you sure you want to change the base?
feat: add ambient mode support to kubeflow controllers #628
Conversation
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kimwnasptd @orfeas-k for review. |
|
This pull request has been automatically marked as stale because it has not had recent activity. Members may comment |
Motivation
This PR makes the Kubeflow controllers (notebook-controller, tensorboard-controller, and pvcviewer-controller)
compatible with Kubernetes Gateway API, which is required for Istio ambient mode support.
Why this change is needed
Istio ambient mode is the service mesh architecture that provides simplified operations and
improved performance. However, it requires different routing resources compared to traditional Istio sidecar
mode:
What this PR accomplishes
VirtualService support
creation
Configuration
This change enables Kubeflow to work seamlessly in both traditional sidecar environments and modern ambient mesh
deployments.
Reference: kubeflow/kubeflow#7736