fix(ios): use iCloud Documents folder for Documents scope #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentsDirectory property was incorrectly using the local sandbox Documents folder instead of the iCloud ubiquity container's Documents folder. This meant files written with CloudStorageScope.Documents were stored locally and not synced to iCloud, contrary to the documented behavior. Fixes kuatsu#53
✅ Deploy Preview for react-native-cloud-storage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #53 -
CloudStorageScope.Documentswas writing to local storage instead of iCloud Documents.The
documentsDirectoryproperty inCloudKitUtils.swiftwas using the local sandbox Documents folder:This has been changed to use the iCloud ubiquity container's Documents folder:
Why This Fix Is Correct
According to Apple's FileManager documentation:
The iCloud ubiquity container has a specific structure where only files in the
Documentssubfolder are visible to users in the Files app. From Apple's iCloud Design Guide:The original implementation used
fileManager.urls(for: .documentDirectory, in: .userDomainMask).firstwhich returns the local app sandbox Documents folder (e.g.,/var/mobile/Containers/Data/Application/{UUID}/Documents/), not the iCloud container at all.Behavior Change
DocumentsAppDataThis aligns with the library's documented behavior which states Documents scope should store data in "the user-visible root directory of the cloud storage".
Test Plan
CloudStorageScope.Documentsto write a fileCloudStorageScope.AppDatastill works as expected (synced but hidden)