Update default Rollback directory#538
Conversation
✅ Deploy Preview for krkn-chaos ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
PR Summary by QodoAlign rollback docs with ~/.krkn/rollback default and remove KubeVirt rollback claim Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
24 rules 1.
|
|
I've updated |
|
@rohIta-k can you separate out the rollback directory changes from the kubevirt rollback removal changes. Want to have 1 change per PR, tia |
Signed-off-by: Rohita <rohitak.srimayee@gmail.com>
Signed-off-by: Rohita <rohitak.srimayee@gmail.com>
Signed-off-by: Rohita <rohitak.srimayee@gmail.com>
4b7f852 to
b2453b9
Compare
Signed-off-by: Rohita <rohitak.srimayee@gmail.com>
|
@paigerube14 i've only included rollback directory changes here, will create an other PR for kubevirt rollback removal changes |
Changes
This PR updates rollback documentation to align with the current implementation in Krkn.
Updated rollback directory references
The documented default rollback directory has been updated from:
to:
This matches the current behavior implemented in Krkn and reflected in runtime logs and tests.
Removed incorrect KubeVirt rollback references
The documentation previously implied that KubeVirt VM outage scenarios participate in the rollback framework.
After reviewing the implementation, KubeVirt VM outage scenarios do not register rollback callables and therefore are not managed through the rollback framework.
Sources
The documentation changes were verified against:
Krkn logs
run_kraken.py
tests/test_rollback.py
KubeVirt VM Outage Scenario Implementation
The scenario does not:
self.rollback_handler.set_rollback_callable(...)Documentation Pages Updated
content/en/docs/rollback-scenarios/index.mdcontent/en/docs/scenarios/kubevirt-vm-outage-scenario/index.mdstatic/search-index.json