docs: fix Tip typo and broken sample-scenario link in service-hijacking#536
docs: fix Tip typo and broken sample-scenario link in service-hijacking#536StrikerEureka34 wants to merge 2 commits into
Conversation
✅ Deploy Preview for krkn-chaos ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
PR Summary by QodoDocs: fix typo and sample-scenario link in service-hijacking docs Description
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
24 rules 1.
|
|
Addressed the bug, can this be reviewed whenever you have a moment. Note:- Please check the updated issue description for more details. |
Signed-off-by: Ayush kumar <nayush2001@gmail.com>
8c83bdc to
7f28743
Compare
|
Hi @StrikerEureka34! 👋 One or more commits in this PR are missing a Unsigned commits:
To fix, rebase and sign off all commits: git rebase HEAD~1 --signoff
git push --force-with-leaseOr, to sign off every commit in this PR at once: git rebase origin/main --signoff
git push --force-with-lease
The |
|
can you fix the CI ? |
I didn't get which one are you referring to. |
|
Yes, CI for the DCO. I think you need to squash all commit and push forcefully. |
| `--scenario-file-path` | The absolute path of the scenario file compiled following the documentation |file_base64 | Yes | | ||
|
|
||
|
|
||
| A sample scenario file can be found [here](service-hijacking-scenarios-krkn.md#sample-scenario), you'll need to customize it based on your wanted response codes for API calls |
There was a problem hiding this comment.
instead of taking out this link would be good to fix the link to point to here or say see krkn page
Documentation Update
Related Feature:
N/A - this is a standalone documentation fix on the existing service-hijacking
scenario page (a typo and a broken internal link).
Changes:
Two small fixes on the service-hijacking scenario docs:
ecause→Because.service-hijacking-scenarios-krkn.mdand rendered as a dead.mdlink.What changed after the recent commit:-
#sample-scenarioanchor, but each tab renders as a separate hidden pane (Docsy tabpane), so the anchor still couldn't activate the Krkn tab from the Krkn-hub or Krknctl tab, and the target content stayed hidden.