docs: clarify pod scenarios using krknctl - docs/pod-scenarios#474
docs: clarify pod scenarios using krknctl - docs/pod-scenarios#474hudazaan wants to merge 2 commits into
Conversation
Signed-off-by: hudazaan <naazhuda2000@gmail.com>
✅ Deploy Preview for krkn-chaos ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Review Summary by QodoClarify pod scenarios documentation and improve krknctl command reference
WalkthroughsDescription• Clarified pod scenario command documentation with improved wording • Reformatted parameter table for better readability and consistency • Enhanced behavior notes with clearer execution flow explanation • Created new dedicated page for krknctl pod scenarios documentation Diagramflowchart LR
A["Pod Scenarios Docs"] -->|"Restructure & Clarify"| B["Updated _tab-krknctl.md"]
A -->|"Create New Page"| C["pod-scenarios-krknctl.md"]
B -->|"Improved Table Format"| D["Better Parameter Reference"]
B -->|"Enhanced Behavior Notes"| E["Clearer Execution Flow"]
File Changes1. content/en/docs/scenarios/pod-scenario/_tab-krknctl.md
|
Code Review by Qodo
1.
|
Signed-off-by: hudazaan <naazhuda2000@gmail.com>
| @@ -1,28 +1,28 @@ | |||
| ```bash | |||
| krknctl run pod-scenarios [--<parameter> <value>] | |||
| krknctl run pod-scenarios [--<parameter>:<value>] | |||
There was a problem hiding this comment.
we can use a space here or colon I think. Think the space is easier to use so lets keep this line as is
| @@ -0,0 +1,14 @@ | |||
| --- | |||
| title: Pod Scenarios using krknctl | |||
There was a problem hiding this comment.
the pod scenarios documentation for krknctl should be in the tabbed page, I don't think we need a separate page for this here as it seems duplicated
|
|
||
| To see the full CLI help: | ||
|
|
||
| To see all available scenario options |
There was a problem hiding this comment.
lets keep this comment here
|
|
||
| - **Recovery monitoring:** After disrupting pods, krkn monitors for recovery up to `--expected-recovery-time` seconds. If any pods remain unrecovered after the timeout, the scenario reports failure. | ||
| - Pods are selected from the namespace and pod filters first, then filtered by node selectors. | ||
| - The scenario fails if the disrupted pods do not recover within `--expected-recovery-time` seconds. |
There was a problem hiding this comment.
can we keep the way the recovery monitoring details are worded. I think it helps clarify there could be multiple pods not all ready/running
Documentation Update
Related Feature: Pod Scenarios using krknctl
Please include the branch name where you have made changes or added new features/scenario that we need on the website (e.g.,
krkn/new_scenario) in the title of this PR.Changes:
krknctl run pod-scenarioscommandFixes issue #84