Conversation
|
@krh gracious ping |
|
@gfxstrand also gracious ping. |
lumag
force-pushed
the
kms
branch
5 times, most recently
from
2704bfa to
a79dc4b
Compare
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
Tested this, and it works!
I just got caught out by init_vt() being called - and disabling all terminal/error output - before the implementation (unchanged here, so we should postpone it to a future PR) hardcodedly opens /dev/dri/card0 (does not exist on my system) and exits without printing any useful error message 😬
(On Intel Arc, card0 is skipped and card1 (but renderD128) is created instead.)
|
@MarijnS95 thanks for the review. Now I hope we can get @krh or @gfxstrand attention. |
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
Latest force-push makes sense, just a rebase on latest master while removing an unintended change in init_headless() and inlining some const struct allocations.
Just a commit-body nit on:
These extensions have been deprecated, Mesa dropped support for it in Mesa, version 22.0.0.
Maybe drop the second Mesa, i.e. ..., Mesa dropped support for it in/since version 22.0.0?
|
@MarijnS95 fixed commit message. @krh @gfxstrand can this be reviewed / merged? |
VkCube supports rendering to bare KMS only if Vulkan supports special set of Intel extensions. These extensions have been deprecated, Mesa dropped support for it in version 22.0.0. Replace vkCreateDmaBufImageINTEL usage with VK_EXT_image_drm_format_modifier and VK_EXT_external_memory_dma_buf. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
2 participants
This switches kms support from using Intel Vulkan extensions (which are not even a part of Mesa anymore) to
VK_EXT_image_drm_format_modifierandVK_EXT_external_memory_dma_buf. I'm opening this as a draft for now to prevent it from being merged for now.