Remove dead --keywords/-k flag from kpt fn eval#4648
Open
aravindtga wants to merge 1 commit into
Open
Conversation
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an unused --keywords/-k flag from kpt fn eval (and its associated plumbing) after the earlier Porch-dependency removal, and updates documentation to eliminate stale references.
Changes:
- Removed the
--keywords/-kflag registration andKeywords []stringfield from thekpt fn evalcommand runner. - Deleted the unused
GetKeywordsFromFlag()helper frompkg/lib/util/cmdutil. - Updated the namespace provisioning CLI guide to remove
--keywordsfrom the autocomplete walkthrough and example command.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| thirdparty/cmdconfig/commands/cmdeval/cmdeval.go | Drops the dead --keywords/-k flag and runner field from kpt fn eval. |
| pkg/lib/util/cmdutil/cmdutil.go | Removes the unused GetKeywordsFromFlag() helper. |
| documentation/content/en/guides/namespace-provisioning-cli.md | Removes stale --keywords references from the guide and example command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aravindtga
marked this pull request as ready for review
July 17, 2026 17:19
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
July 17, 2026 17:19
kushnaidu
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--keywords/-kflag fromkpt fn eval, itsKeywords []stringstruct field, and the unusedGetKeywordsFromFlag()helper. Updated thenamespace-provisioning-cliguide to remove stale--keywordsreferences.SuggestFunctions()andSuggestKeywords()). The flag was never consumed at runtime and passing it had no effect on function execution.kpt fn eval --help.Type of Change
Checklist
AI Disclosure
If so, please describe how:
- Kiro to analyse the flag's history, and generate the PR message.