Skip to content

Remove dead --keywords/-k flag from kpt fn eval#4648

Open
aravindtga wants to merge 1 commit into
kptdev:mainfrom
Nordix:remove-dead-keywords-flag
Open

Remove dead --keywords/-k flag from kpt fn eval#4648
aravindtga wants to merge 1 commit into
kptdev:mainfrom
Nordix:remove-dead-keywords-flag

Conversation

@aravindtga

Copy link
Copy Markdown
Contributor

Description

  • What changed: Removed the orphaned --keywords/-k flag from kpt fn eval, its Keywords []string struct field, and the unused GetKeywordsFromFlag() helper. Updated the namespace-provisioning-cli guide to remove stale --keywords references.
  • Why it's needed: The flag was left behind as dead code when Complete transfer of kpt updates from Porch to kpt #4355 removed the Porch dependency from kpt. It was originally introduced in feat: Kpt CLI Function discovery #2980 for shell tab-completion only (filtering Porch function catalog suggestions via SuggestFunctions() and SuggestKeywords()). The flag was never consumed at runtime and passing it had no effect on function execution.
  • How it works: Removes the flag registration, struct field, and helper function. No behavioral change other than the flag no longer appearing in kpt fn eval --help.

Type of Change

  • Refactor
  • Documentation

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

AI Disclosure

  • I have used AI in the creation of this PR.

If so, please describe how:
- Kiro to analyse the flag's history, and generate the PR message.

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@aravindtga aravindtga self-assigned this Jul 17, 2026
@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 650d9ef
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a5a61300752da0008abf114
😎 Deploy Preview https://deploy-preview-4648--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused --keywords/-k flag from kpt fn eval (and its associated plumbing) after the earlier Porch-dependency removal, and updates documentation to eliminate stale references.

Changes:

  • Removed the --keywords/-k flag registration and Keywords []string field from the kpt fn eval command runner.
  • Deleted the unused GetKeywordsFromFlag() helper from pkg/lib/util/cmdutil.
  • Updated the namespace provisioning CLI guide to remove --keywords from the autocomplete walkthrough and example command.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
thirdparty/cmdconfig/commands/cmdeval/cmdeval.go Drops the dead --keywords/-k flag and runner field from kpt fn eval.
pkg/lib/util/cmdutil/cmdutil.go Removes the unused GetKeywordsFromFlag() helper.
documentation/content/en/guides/namespace-provisioning-cli.md Removes stale --keywords references from the guide and example command.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aravindtga
aravindtga marked this pull request as ready for review July 17, 2026 17:19
@aravindtga
aravindtga requested review from a team July 17, 2026 17:19
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. cleanup documentation Improvements or additions to documentation labels Jul 17, 2026
@dosubot dosubot Bot added the lgtm label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup documentation Improvements or additions to documentation lgtm size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants