Changed pixel-width to percentage for loaded- and process-bar#80
Open
SimonSimCity wants to merge 1 commit intokolber:masterfrom
Open
Changed pixel-width to percentage for loaded- and process-bar#80SimonSimCity wants to merge 1 commit intokolber:masterfrom
SimonSimCity wants to merge 1 commit intokolber:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the pixel-calculated width (sorry for the typo in the commit-message) to percentage to gain more flexibility.
I am using it in a use-case, where the process-bar fills the whole screen-width. As this is a mobile-app, the screen-width is flexible at runtime because the user can f.e. switch from portrait to landscape.
The best way I could think of (instead of using some trigger that fires on browser-resize) was to replace the pixel calculation by percentage.