KDS-626: Migrate to KdsCheckboxGroup#156
Conversation
RainerSchmoeger
requested review from
knime-ghub-bot
and removed request for
a team
🦋 Changeset detectedLatest commit: 8ec032d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR migrates from the legacy Checkboxes component to the new KdsCheckboxGroup component from the KDS component library.
Changes:
- Updated KDS component and style library versions from 0.5.10 to 0.6.1
- Replaced
Checkboxesimport withKdsCheckboxGroupin CheckboxesControl component - Added accessibility improvement by including a title attribute for the hide-on-null checkbox
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updated KDS dependencies to version 0.6.1 to support the new KdsCheckboxGroup component |
| packages/jsonforms/src/uiComponents/CheckboxesControl.vue | Migrated from Checkboxes to KdsCheckboxGroup component and removed the is-valid prop |
| packages/jsonforms/src/uiComponents/composables/useHideOnNull.ts | Added title attribute for accessibility to describe the hide-on-null checkbox purpose |
| .changeset/fair-spoons-taste.md | Added changelog entry documenting the migration |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| :possible-values="options" | ||
| :alignment="alignment" | ||
| :disabled="disabled" | ||
| :model-value="control.data" |
There was a problem hiding this comment.
The removal of the :is-valid prop may affect validation behavior. Ensure there is test coverage verifying that validation still works correctly with KdsCheckboxGroup.
There was a problem hiding this comment.
We moved the error detection and colors to the options...
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/jsonforms/src/uiComponents/CheckboxesControl.vue:1
- The removed :is-valid prop was likely used for validation styling. Verify that KdsCheckboxGroup handles validation state internally or ensure validation feedback is provided through another mechanism.
<script setup lang="ts">
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/jsonforms/src/uiComponents/composables/useHideOnNull.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@RainerSchmoeger I've opened a new pull request, #157, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RainerSchmoeger
force-pushed
the
enh/KDS-626-migrate-checkbox-group
branch
from
40d0095 to
8db5c04
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RainerSchmoeger
force-pushed
the
enh/KDS-626-migrate-checkbox-group
branch
from
4809415 to
8ec032d
Compare
|
KDS-626 (CheckboxGroup)