Conversation
RainerSchmoeger
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
|
There was a problem hiding this comment.
Pull request overview
This PR removes PostCSS as a dependency and processing tool from the jsonforms package. The changes update all Vue single-file components to use plain CSS instead of PostCSS, remove PostCSS configuration, and eliminate the dependency from the build setup.
Changes:
- Removed PostCSS dependency from package.json and build configuration
- Updated all Vue component style blocks from
lang="postcss"to plain CSS - Replaced PostCSS nesting syntax with standard CSS in one component
- Deleted the PostCSS configuration file
Reviewed changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/jsonforms/vite.config.js | Removed PostCSS import and CSS configuration from Vite config |
| packages/jsonforms/postcss.config.cjs | Deleted PostCSS configuration file entirely |
| packages/jsonforms/package.json | Removed postcss dependency |
| packages/jsonforms/src/uiComponents/CheckboxControl.vue | Changed from PostCSS to plain CSS and updated nesting syntax |
| Multiple Vue component files (29 files) | Removed lang="postcss" attribute from style blocks |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| margin-bottom: -10px; | ||
|
|
||
| & .checkbox-container { | ||
| .checkbox-container { |
There was a problem hiding this comment.
The PostCSS nesting syntax & .checkbox-container has been replaced with .checkbox-container. However, this change modifies the CSS selector specificity. The original selector was .checkbox-input .checkbox-container (more specific), while the new selector targets any .checkbox-container (less specific). This could cause unintended styling changes if .checkbox-container exists elsewhere in the component or application. Consider using .checkbox-input .checkbox-container to maintain the original specificity.
| <style lang="postcss" scoped> | ||
| <style scoped> | ||
| .set-button { | ||
| & span { |
There was a problem hiding this comment.
This selector still uses PostCSS nesting syntax (& span) despite the removal of lang="postcss". This should be updated to .set-button span to work with plain CSS, similar to the fix applied in CheckboxControl.vue.
| <style lang="postcss" scoped> | ||
| <style scoped> | ||
| .section { | ||
| &:not(:first-child) { |
There was a problem hiding this comment.
This selector still uses PostCSS nesting syntax (&:not(:first-child)) despite the removal of lang="postcss". This should be updated to .section:not(:first-child) to work with plain CSS.
|
1 participant
No description provided.