Use Status subresource #110
Conversation
Uses the kubebuilder:subresource:status annotation.
The SDK can't use the status subresource because it doesn't know at time of update if finalizers have changed. Added a TODO to refactor update so if finalizers didn't change, the status subresource is used instead.
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
size/M
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This may have caused test failures in eventing. The evidence I used to confirm that GKE supported the status subresource was knative/serving#786, which may not have been quite as authoritative as it should have been 😄 @dprotaso do you know the state of GKE's support for CRD subresources? |
|
After some more research I think the feature is actually enabled, so false alarm there. More details in #114. |
This reverts commit 8bd4fe5.
|
@grantr It's beta in 1.11 so it's on by default. Thus you can 'enable' the status subresource on your CRDs |
4 participants
Now that GKE has 1.11 available we can use the status subresource for CRDs. This eliminates the need to manipulate
Spec.Generation, which is good because eventing-sources doesn't do that yet.Proposed Changes
Release Note