Skip to content

Conversation

evankanderson
Copy link
Member

Related to #6305 and #6412

Proposed Changes

  • The previous "install" pages (which included upgrade and uninstall) were moved to Administration in Move install docs to administration #6403, but there were still a lot of "how to install" documents scattered throughout the repo (particularly in eventing)
  • Similarly, administration topics for configuring Knative were scattered between "Serving" and "Eventing", and pages which could be done by non-privileged users were mixed with documents that required administrator privileges to run.
    • I had to split the Kafka and RabbitMQ broker docs, but most docs clearly targeted one role or another.
  • This PR does not generally move the actual pages (and URLs), but instead restructures the navigation. This somewhat kicks the can of moving things down the road. I chose to do this because:
    1. Given past history, this may need a little time to settle, and moving documents means we need to put in redirects (more toil)
    2. Moving document means updating links, and I'd like to fix a bunch of the internal link warnings in --strict mode, so we can detect when we break these links with higher reliability.

Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit d012b43
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68e57af91602f800088e9e84
😎 Deploy Preview https://deploy-preview-6428--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@knative-prow knative-prow bot requested review from creydr, dprotaso and nainaz October 7, 2025 20:41
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 7, 2025
@evankanderson
Copy link
Member Author

@evankanderson
Copy link
Member Author

/assign @iRaindrop @dprotaso

Copy link

knative-prow bot commented Oct 7, 2025

@evankanderson: GitHub didn't allow me to assign the following users: iRaindrop.

Note that only knative members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @iRaindrop @dprotaso

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iRaindrop
Copy link
Contributor

It's a good restructuring. Good to the Administrator node with content that applies to both Serving and Eventing. Navigation is more intuitive. Important concepts are more prominent.

@dprotaso
Copy link
Member

dprotaso commented Oct 8, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2025
Copy link

knative-prow bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

dprotaso commented Oct 8, 2025

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 5712cad into knative:main Oct 8, 2025
19 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6430

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants