docs: fix broken jsonpath in kubectl logs verification command#316
docs: fix broken jsonpath in kubectl logs verification command#316Shruti2110-coder wants to merge 1 commit into
Conversation
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @Shruti2110-coder! It looks like this is your first PR to kmesh-net/website 🎉 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the command used to retrieve Kmesh logs in the quick-start documentation by replacing a complex subshell pod query with a simpler label selector (-l app=kmesh). There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Updates the Quick Start installation verification command to reliably fetch Kmesh logs by replacing an invalid JSONPath expression in the kubectl logs step.
Changes:
- Replace broken
kubectl get pods ... -o jsonpath='{.items.metadata.name}'usage with a label-selector basedkubectl logscommand in the Quick Start verification section.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```shell | ||
| kubectl logs -n kmesh-system $(kubectl get pods -n kmesh-system -o jsonpath='{.items.metadata.name}') | ||
| kubectl logs -n kmesh-system -l app=kmesh |
|
|
||
| ```shell | ||
| kubectl logs -n kmesh-system $(kubectl get pods -n kmesh-system -o jsonpath='{.items.metadata.name}') | ||
| kubectl logs -n kmesh-system -l app=kmesh |
Signed-off-by: Shruti2110-coder <your-github-email@example.com>
Shruti2110-coder
force-pushed
the
fix-jsonpath-issue-297
branch
from
3fa84ae to
0037471
Compare
What this fixes
Fixes #297
The
kubectl logscommand in the Quick Start verification step used an invalid JSONPath expression ({.items.metadata.name}), which fails silently becauseitemsis an array and can't be accessed with.metadata.namedirectly.Change
Replaced the broken JSONPath lookup with a label-selector based command, as recommended in the issue:
Testing
Verified the new command correctly retrieves logs for the kmesh pod using the label selector.