JQ Dependency check/install and GPS change from Ruby to Python #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ruby is used so little, I was wondering if a easy Python script is better or using maidenhead. |
Author
|
Knocked up a quick Python script to do that job. It is using python3 which I know can be divisive. Need to do a little bit more testing to see how it handles not having a GPS lock and GPS not being attached and update error handling accordingly but the happy path of the code works. |
|
Fun this would be one less requirement for the project, as for Python3 it's the future 2 is doa |
kbball
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that jq was not call out as a dependency and if not installed, it failed silently and acted as if the grid square was not correctly set. Added logic to check for jq and if not to install similar to the ruby logic already existing.
Additionally, ruby 2.3 is EOL with ruby 2.7 going EOL in about two months. Bump the ruby version to ruby 3 which has been running fine on my evolve3.