Skip to content

Conversation

@piboistudios
Copy link

No description provided.

cache.destroy();
},

FAIL: standardReply,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually okay with adding this, but I get the sentiment for now at least it should follow the other style guide.

for example :

FAIL: function(command, handler) {
 const [command, code, ...context] = command.params;
   ...
}

The naming convention is close but just for consistency we can use command

description is also obligatory for the server side, so it probably should also be added.

Also while context is in the spec, it should be documented for the IRC3 implementation here too.

For brevity the spec is listed here : https://ircv3.net/specs/extensions/standard-replies

It would be nice to also add the documentation of it somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants