-
Notifications
You must be signed in to change notification settings - Fork 51
feature: options for dependencies #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Good idea, I can keep the PR open and then we could merge the whole feature. |
|
Oh I guess you got the extras/requires thing figured out? |
|
Yeah, sorry about the noise, I figured it out. |
e376b73 to
01545de
Compare
|
Ok, please feel free to have a look. I also updated some of the printlns but will be happy to revert, if it's not in line with some conventions etc. |
7d99856 to
3f84808
Compare
|
Overall looks good to me, happy to merge it and push up a new release if there's nothing more you're thinking o adding. |
|
This one is ok to merge, from my perspective; I'll create a separate PR for post-install commands if that's fine with you. Edit: Fixed typos. |
<!-- ps-id: 7d8df5b4-5c44-42eb-8f34-d6f23660fe93 -->
<!-- ps-id: bc69715d-8c9e-4bfe-9aec-bb348c037204 -->
3f84808 to
cd16b84
Compare
|
hmm doing some testing with a project and seeing after bumping up kit-generator I'm guessing it's the |
|
I'll look into that. I didn't get to manual testing yet. ;> Edit: Yeah, mistyped |
|
No worries, we'll have to test with an actual project to make sure everything works, then I can push up a new template with the changes. |
Added more tests in preparation of adding support for more advanced feature flags.