Skip to content

Conversation

@bilus
Copy link
Contributor

@bilus bilus commented Jan 1, 2026

Added more tests in preparation of adding support for more advanced feature flags.

@yogthos
Copy link
Collaborator

yogthos commented Jan 1, 2026

Good idea, I can keep the PR open and then we could merge the whole feature.

@yogthos
Copy link
Collaborator

yogthos commented Jan 2, 2026

Oh I guess you got the extras/requires thing figured out?

@bilus
Copy link
Contributor Author

bilus commented Jan 2, 2026

Yeah, sorry about the noise, I figured it out.

@bilus bilus force-pushed the bilus/more-tests branch from e376b73 to 01545de Compare January 2, 2026 23:25
@bilus bilus changed the title more tests feature: options for dependencies Jan 2, 2026
@bilus
Copy link
Contributor Author

bilus commented Jan 2, 2026

Ok, please feel free to have a look. I also updated some of the printlns but will be happy to revert, if it's not in line with some conventions etc.

@bilus bilus force-pushed the bilus/more-tests branch 3 times, most recently from 7d99856 to 3f84808 Compare January 2, 2026 23:39
@yogthos
Copy link
Collaborator

yogthos commented Jan 2, 2026

Overall looks good to me, happy to merge it and push up a new release if there's nothing more you're thinking o adding.

@bilus
Copy link
Contributor Author

bilus commented Jan 3, 2026

This one is ok to merge, from my perspective; I'll create a separate PR for post-install commands if that's fine with you.

Edit: Fixed typos.

bilus added 2 commits January 3, 2026 09:28
<!-- ps-id: 7d8df5b4-5c44-42eb-8f34-d6f23660fe93 -->
<!-- ps-id: bc69715d-8c9e-4bfe-9aec-bb348c037204 -->
@bilus bilus force-pushed the bilus/more-tests branch from 3f84808 to cd16b84 Compare January 3, 2026 08:28
@yogthos yogthos merged commit 15510e9 into kit-clj:master Jan 3, 2026
1 check passed
@yogthos
Copy link
Collaborator

yogthos commented Jan 3, 2026

hmm doing some testing with a project and seeing after bumping up kit-generator

(kit/sync-modules)
Execution error (FileNotFoundException) at java.io.FileInputStream/open0 (FileInputStream.java:-2).
kit-edn (No such file or directory)

I'm guessing it's the sync-modules bit.

@bilus
Copy link
Contributor Author

bilus commented Jan 3, 2026

I'll look into that. I didn't get to manual testing yet. ;>

Edit: Yeah, mistyped "kit-edn".

@yogthos
Copy link
Collaborator

yogthos commented Jan 3, 2026

No worries, we'll have to test with an actual project to make sure everything works, then I can push up a new template with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants