-
Notifications
You must be signed in to change notification settings - Fork 6
Feature/communities tinder #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
- There are TinderAnswers for each community, and they're accessible and editable from the CommunitiesController - Other minor changes
6b0ae11 to
2609f29
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
backend/src/main/kotlin/hu/bme/sch/cmsch/component/communities/TinderService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/hu/bme/sch/cmsch/component/communities/TinderService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/hu/bme/sch/cmsch/component/communities/CommunitiesController.kt
Show resolved
Hide resolved
| return "admin403" | ||
| } | ||
|
|
||
| val questions = transactionManager.transaction(readOnly = true) { tinderService.getAllQuestions() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opening a lot of short transactions, maybe mark the public methods as @Transactional instead?
Isti01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing something, but I think the endpoints for the tinder interaction are missing
New functionality: tinder!
The organizers can give single choice questions with the answer options, and they can answer these questions with communities from /admin/control/community. No answers are required.
There is also an API endpoint for submitting answers to the tinder questions by users as well, and an endpoint for retrieving the communities ordered by the number of matching answers with the user.