Skip to content

fix setting recurly error when using RecurlyErrors class #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix setting recurly error when using RecurlyErrors class #487

wants to merge 1 commit into from

Conversation

@BartoszRackowski
Copy link

@BartoszRackowski BartoszRackowski commented Jan 14, 2025

this.recurlyErrors = (RecurlyErrors) recurlyErrors; is not working
this.recurlyErrors = (RecurlyErrors) recurlyErrors; is equivalent to this.recurlyErrors = this.recurlyErrors; which assigns value to itself (non initialized, null effectively).

This change is to fix this issue by assigning recurlyError from param, also covered by tests.

DamianKaczmarczykK
DamianKaczmarczykK approved these changes Jan 14, 2025
View reviewed changes
Copy link

@DamianKaczmarczykK DamianKaczmarczykK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test if I can give approval
EDIT: security is too good to bypass (mission failed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DamianKaczmarczykK DamianKaczmarczykK DamianKaczmarczykK approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BartoszRackowski @DamianKaczmarczykK