Open
Conversation
Merge pull request khampf#18 from tmackay/master
Bind keyup pipe
previous logic does not check if previously active before resending press event every poll also uses unnecessary local variable and multiple unnecessary assignments every poll seems much snappier now (or just me?)
Expensive coordinate transform was being performed on every poll, instead use pre-calculated zones, however calibration is no longer effective. This actually increased CPU from 3-4% to 7% due to being able to read more samples so a delay was added to the main loop to limit stick polling frequency, dropping CPU utilization to 0.7% during rapid stick movement.
50Hz was slightly noticeable
Doesn't seem necessary for keys, but mouse buttons don't work unless we sync between press and release events. Applies to keydown/keyup bindings.
failed to pull before making local changes
Blocking read of USB events times out after 100ms - only sleep after an event was received to prevent "windows" of unnecessary delay after each timeout.
Added constants for G13_KEY_READ_TIMEOUT (100ms) and G13_KEY_READ_MIN_TIME (10ms) for USB blocking read timeout and minimum time between event parsing respectively.
Set G13_KEY_READ_MIN_TIME to non-zero value, eg. 10 (milliseconds) to reduce CPU utilization by skipping stick samples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves stickzone efficiency and reliability by limiting maximum sampling frequency and performing coordinate transformation of zone in advance. Does not take into consideration centre or bounds calibration which add little value. Is this worth re-implementing?
fixes #21