Piezo Speaker Tune/Melody Functionality#1515
Draft
jackhumbert wants to merge 2 commits intokeyboardio:masterfrom
Draft
Piezo Speaker Tune/Melody Functionality#1515jackhumbert wants to merge 2 commits intokeyboardio:masterfrom
jackhumbert wants to merge 2 commits intokeyboardio:masterfrom
Conversation
Signed-off-by: Jack Humbert <jack.humb@gmail.com>
Signed-off-by: Jack Humbert <jack.humb@gmail.com>
5b6c567 to
143fd35
Compare
Member
|
<3 #1512 is kind of what I'd been thinking for how to do 'themes' for different events. I suspect we'd also want it to listen to events the way the LEDIndicators plugin does. |
Author
|
Ah, I didn't see that! I should have dug deeper. It's funny how we ended up with similar This is great, though - I love the phonemes! I'll check it out and play around with it. |
Member
|
I wish the phonemes worked at all. They totally don't :)
…On Tue, Jul 22, 2025 at 2:58 PM Jack Humbert ***@***.***> wrote:
*jackhumbert* left a comment (keyboardio/Kaleidoscope#1515)
<#1515 (comment)>
Ah, I didn't see that! I should have dug deeper. It's funny how we ended
up with similar playNextNote methods :)
This is great, though - I love the phonemes! I'll check it out and play
around with it.
—
Reply to this email directly, view it on GitHub
<#1515 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALC2CWV5KQ5LQ6GYHZNLD3J2XYTAVCNFSM6AAAAACCEB66ASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBUHE2DINZUHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes some methods virtual for overriding, and allows initializer lists for nice calls like this:
kaleidoscope::Runtime.device().speaker().playTune( {440, 880, 440, 880}, {50, 50, 200, 50} );