Skip to content

Add durable profile acceptance fixtures - #90

Merged
IlyaasK merged 1 commit into
mainfrom
hypeship/profile-acceptance-fixture
Jul 29, 2026
Merged

Add durable profile acceptance fixtures#90
IlyaasK merged 1 commit into
mainfrom
hypeship/profile-acceptance-fixture

Conversation

@IlyaasK

@IlyaasK IlyaasK commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add durable profile create/delete methods to the provider-local Kernel client
  • preserve explicit project scope and disable SDK retries for both mutations
  • add guarded, deadline-bound cleanup for acceptance profile fixtures
  • test cleanup gating, default and explicit scope, 404 handling, and deletion errors
  • keep profile archive download outside the provider-local client surface

Why

The existing kernel_profile data source needs a real durable fixture for live acceptance coverage. This PR adds only the setup and cleanup boundary; it does not add a Terraform profile resource or change provider behavior.

Scope

internal/kernelclient continues to expose durable operations only. This PR does not expose profile archive download, browser-session profile saves, or any runtime operation.

The profile data-source acceptance scenario and workflow entry remain in the next stacked PR.

Tests

  • go test -short -timeout=2m ./internal/acctest ./internal/kernelclient
  • go test -race -short -timeout=2m ./internal/acctest ./internal/kernelclient
  • go test -short -timeout=2m ./...
  • go vet ./...
  • go mod verify
  • go mod tidy -diff
  • gofmt -l cmd internal
  • terraform fmt -check -recursive examples
  • bash scripts/check-docs.sh
  • bash scripts/check-markdown-links.sh

No live API call is part of this fixture-plumbing PR.


Note

Low Risk
Test and internal client helper changes only; no provider resources or production code paths.

Overview
Adds acceptance-test plumbing so durable Kernel profiles can be created and torn down for upcoming live coverage (e.g. kernel_profile), without changing Terraform provider behavior.

internal/kernelclient gains CreateProfile and DeleteProfile, using explicit project scope and disabled SDK retries on mutations (same pattern as other durable writes). Client tests cover those endpoints and assert DownloadProfile is not on the Clients surface.

internal/acctest adds CleanupProfile, mirroring existing project/browser-pool cleanup: gated on acceptance env + API key, optional default project resolution, deadline-bound delete, and 404 treated as already clean. New unit tests exercise gating, scope, errors, and cleanup registration.

Reviewed by Cursor Bugbot for commit 1699975. Bugbot is set up for automated code reviews on this repo. Configure here.

@IlyaasK
IlyaasK marked this pull request as ready for review July 11, 2026 17:55
@IlyaasK
IlyaasK requested review from Sayan- and tnsardesai and removed request for Sayan- and tnsardesai July 11, 2026 17:55
@IlyaasK
IlyaasK force-pushed the hypeship/extension-qualified-import-acceptance branch from 4be75b8 to baff9e7 Compare July 13, 2026 13:35
@IlyaasK
IlyaasK force-pushed the hypeship/profile-acceptance-fixture branch from f261fcf to ebe560c Compare July 13, 2026 13:35
@IlyaasK
IlyaasK force-pushed the hypeship/extension-qualified-import-acceptance branch from baff9e7 to 84d2e8f Compare July 13, 2026 14:32
@IlyaasK
IlyaasK force-pushed the hypeship/profile-acceptance-fixture branch 2 times, most recently from 8015701 to edbd925 Compare July 13, 2026 15:39
@IlyaasK
IlyaasK force-pushed the hypeship/extension-qualified-import-acceptance branch from 84d2e8f to e245f76 Compare July 13, 2026 15:39
@IlyaasK
IlyaasK force-pushed the hypeship/extension-qualified-import-acceptance branch from e245f76 to bfed729 Compare July 20, 2026 19:38
@IlyaasK
IlyaasK force-pushed the hypeship/profile-acceptance-fixture branch 4 times, most recently from d46c205 to bf17abf Compare July 21, 2026 19:51
@IlyaasK
IlyaasK force-pushed the hypeship/extension-qualified-import-acceptance branch from 482edca to 86b58f3 Compare July 21, 2026 20:15
@IlyaasK
IlyaasK force-pushed the hypeship/profile-acceptance-fixture branch 2 times, most recently from 18714b7 to cf2406a Compare July 27, 2026 19:58
@IlyaasK
IlyaasK changed the base branch from hypeship/extension-qualified-import-acceptance to hypeship/project-data-source-acceptance July 27, 2026 19:58
@IlyaasK
IlyaasK force-pushed the hypeship/profile-acceptance-fixture branch from cf2406a to 1d4b930 Compare July 27, 2026 19:58
@IlyaasK
IlyaasK requested a review from Sayan- July 27, 2026 21:06
@IlyaasK
IlyaasK changed the base branch from hypeship/project-data-source-acceptance to main July 29, 2026 14:10
@IlyaasK
IlyaasK force-pushed the hypeship/profile-acceptance-fixture branch from 1d4b930 to 1699975 Compare July 29, 2026 14:10
@IlyaasK
IlyaasK merged commit 8c20b96 into main Jul 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants