Add durable profile acceptance fixtures - #90
Merged
Conversation
IlyaasK
marked this pull request as ready for review
July 11, 2026 17:55
IlyaasK
requested review from
Sayan- and
tnsardesai
and removed request for
Sayan- and
tnsardesai
July 11, 2026 17:55
IlyaasK
force-pushed
the
hypeship/extension-qualified-import-acceptance
branch
from
July 13, 2026 13:35
4be75b8 to
baff9e7
Compare
IlyaasK
force-pushed
the
hypeship/profile-acceptance-fixture
branch
from
July 13, 2026 13:35
f261fcf to
ebe560c
Compare
IlyaasK
force-pushed
the
hypeship/extension-qualified-import-acceptance
branch
from
July 13, 2026 14:32
baff9e7 to
84d2e8f
Compare
IlyaasK
force-pushed
the
hypeship/profile-acceptance-fixture
branch
2 times, most recently
from
July 13, 2026 15:39
8015701 to
edbd925
Compare
IlyaasK
force-pushed
the
hypeship/extension-qualified-import-acceptance
branch
from
July 13, 2026 15:39
84d2e8f to
e245f76
Compare
IlyaasK
force-pushed
the
hypeship/extension-qualified-import-acceptance
branch
from
July 20, 2026 19:38
e245f76 to
bfed729
Compare
IlyaasK
force-pushed
the
hypeship/profile-acceptance-fixture
branch
4 times, most recently
from
July 21, 2026 19:51
d46c205 to
bf17abf
Compare
IlyaasK
force-pushed
the
hypeship/extension-qualified-import-acceptance
branch
from
July 21, 2026 20:15
482edca to
86b58f3
Compare
IlyaasK
force-pushed
the
hypeship/profile-acceptance-fixture
branch
2 times, most recently
from
July 27, 2026 19:58
18714b7 to
cf2406a
Compare
IlyaasK
changed the base branch from
hypeship/extension-qualified-import-acceptance
to
hypeship/project-data-source-acceptance
July 27, 2026 19:58
IlyaasK
force-pushed
the
hypeship/profile-acceptance-fixture
branch
from
July 27, 2026 19:58
cf2406a to
1d4b930
Compare
Sayan-
approved these changes
Jul 28, 2026
IlyaasK
changed the base branch from
hypeship/project-data-source-acceptance
to
main
July 29, 2026 14:10
IlyaasK
force-pushed
the
hypeship/profile-acceptance-fixture
branch
from
July 29, 2026 14:10
1d4b930 to
1699975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The existing
kernel_profiledata source needs a real durable fixture for live acceptance coverage. This PR adds only the setup and cleanup boundary; it does not add a Terraform profile resource or change provider behavior.Scope
internal/kernelclientcontinues to expose durable operations only. This PR does not expose profile archive download, browser-session profile saves, or any runtime operation.The profile data-source acceptance scenario and workflow entry remain in the next stacked PR.
Tests
go test -short -timeout=2m ./internal/acctest ./internal/kernelclientgo test -race -short -timeout=2m ./internal/acctest ./internal/kernelclientgo test -short -timeout=2m ./...go vet ./...go mod verifygo mod tidy -diffgofmt -l cmd internalterraform fmt -check -recursive examplesbash scripts/check-docs.shbash scripts/check-markdown-links.shNo live API call is part of this fixture-plumbing PR.
Note
Low Risk
Test and internal client helper changes only; no provider resources or production code paths.
Overview
Adds acceptance-test plumbing so durable Kernel profiles can be created and torn down for upcoming live coverage (e.g.
kernel_profile), without changing Terraform provider behavior.internal/kernelclientgainsCreateProfileandDeleteProfile, using explicit project scope and disabled SDK retries on mutations (same pattern as other durable writes). Client tests cover those endpoints and assertDownloadProfileis not on theClientssurface.internal/acctestaddsCleanupProfile, mirroring existing project/browser-pool cleanup: gated on acceptance env + API key, optional default project resolution, deadline-bound delete, and 404 treated as already clean. New unit tests exercise gating, scope, errors, and cleanup registration.Reviewed by Cursor Bugbot for commit 1699975. Bugbot is set up for automated code reviews on this repo. Configure here.