Skip to content

Add manual acceptance workflow - #29

Merged
IlyaasK merged 1 commit into
hypeship/v0-ci-correctnessfrom
hypeship/v0-acceptance-workflow
Jul 2, 2026
Merged

Add manual acceptance workflow#29
IlyaasK merged 1 commit into
hypeship/v0-ci-correctnessfrom
hypeship/v0-acceptance-workflow

Conversation

@IlyaasK

@IlyaasK IlyaasK commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a manual workflow_dispatch acceptance workflow for browser-pool acceptance tests.
  • Gate the workflow on repository secrets for KERNEL_API_KEY and KERNEL_PROJECT_ID.
  • Preserve optional KERNEL_ALT_PROJECT_ID and KERNEL_BASE_URL support.
  • Update the release checklist with the manual workflow path and a cache-bypassing local acceptance command.

Why this is v0 work

v0 needs a documented, opt-in way to run real API acceptance tests before tagging. This workflow makes that release gate repeatable without running live Kernel resource tests on every PR.

Intentionally unsupported in v0

  • Acceptance tests are not added to PR or push CI.
  • The workflow does not acquire, release, flush, invoke apps, fetch logs, take screenshots, open live view, or force-recover runtime state.
  • No v1 resources, force_destroy, or codegen work is included.

Tests run

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/acceptance.yml"); YAML.load_file(".github/workflows/ci.yml")'
  • bash scripts/check-markdown-links.sh
  • bash scripts/check-examples.sh
  • gofmt -l cmd internal
  • go test -short -timeout=2m ./...
  • go vet ./...
  • terraform fmt -check -recursive examples
  • bash scripts/check-docs.sh
  • git diff --check hypeship/v0-ci-correctness
  • git diff --cached --check

Acceptance-test status

The live acceptance tests were not run locally because credentials are not present in this environment. This PR adds the manual release workflow that should be run before a v0 tag with KERNEL_API_KEY and KERNEL_PROJECT_ID configured.

Review gates

  • deslop: clean, no accepted findings.
  • incremental self-pr review: accepted one command mismatch and updated the release checklist to use -count=1 -timeout=30m -v; fixed.
  • autoreview: clean, no accepted/actionable findings reported.
  • dave-cheney-go-review: clean; workflow uses the existing Go acceptance harness without changing Go cleanup, import, or durable client semantics.
  • eblog-code-review: clean; acceptance lifecycle is manual, secrets-gated, timeout-bounded, and kept out of ordinary PR CI.
  • final agreement pass: clean; workflow is manual-only, secrets-gated, and uses the existing acceptance harness.

Deferred v1 issues

Remaining manual release gates

  • Configure acceptance-test repository secrets.
  • Run the manual Acceptance workflow or the documented local acceptance command before tagging v0.
  • Merge the v0 stack onto the canonical branch and confirm release signing/checksum ownership before publishing.

Note

Low Risk
CI and documentation only; no provider or test harness logic changes, though the workflow can create real Kernel resources when triggered with valid secrets.

Overview
Adds a manual-only GitHub Actions workflow (workflow_dispatch) so browser-pool acceptance tests can run against live Kernel credentials without running on every PR.

The job sets TF_ACC / KERNEL_ACC, wires KERNEL_* secrets (required API key and project ID; optional alt project and base URL), fails fast if secrets are missing, installs Go and Terraform, and runs go test -count=1 -timeout=30m -v ./internal/resources/browserpool -run TestAcc with a 40-minute job timeout so setup does not cut off test cleanup.

docs/release.md now documents the same local acceptance command and points release maintainers at the new Acceptance workflow as an alternative to running tests locally.

Reviewed by Cursor Bugbot for commit 398d8e5. Bugbot is set up for automated code reviews on this repo. Configure here.

@IlyaasK
IlyaasK marked this pull request as ready for review July 1, 2026 21:07
@IlyaasK
IlyaasK requested review from Sayan- and tnsardesai July 1, 2026 21:07

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1b274e5. Configure here.

Comment thread .github/workflows/acceptance.yml
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from ec173ee to 6a9a6ea Compare July 2, 2026 02:34
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from 1b274e5 to f57bed1 Compare July 2, 2026 02:34
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from 6a9a6ea to d5585c1 Compare July 2, 2026 02:48
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from f57bed1 to cdacece Compare July 2, 2026 02:48
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from d5585c1 to 9a1c02b Compare July 2, 2026 19:51
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from cdacece to 12a7648 Compare July 2, 2026 19:51
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from 9a1c02b to a7e4426 Compare July 2, 2026 20:03
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from 12a7648 to 943e249 Compare July 2, 2026 20:03
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from a7e4426 to b735188 Compare July 2, 2026 20:15
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch 2 times, most recently from 3c0182f to 904816a Compare July 2, 2026 20:25
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from b735188 to c352284 Compare July 2, 2026 20:25
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from 904816a to f8e56a1 Compare July 2, 2026 20:37
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from c352284 to 020ce52 Compare July 2, 2026 20:37
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from f8e56a1 to 38ae528 Compare July 2, 2026 20:47
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch 2 times, most recently from 91cfe71 to 816dbf9 Compare July 2, 2026 20:52
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch 2 times, most recently from 70e8f9a to ff4ede2 Compare July 2, 2026 20:57
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from 816dbf9 to 4756fcd Compare July 2, 2026 20:57
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from ff4ede2 to d40c0c5 Compare July 2, 2026 21:22
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from 4756fcd to 5e54cef Compare July 2, 2026 21:22
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from d40c0c5 to d1ec25b Compare July 2, 2026 22:00
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from 5e54cef to 36d00ac Compare July 2, 2026 22:00
@IlyaasK
IlyaasK force-pushed the hypeship/v0-ci-correctness branch from 36d00ac to 49bd5c2 Compare July 2, 2026 22:05
@IlyaasK
IlyaasK force-pushed the hypeship/v0-acceptance-workflow branch from d1ec25b to 398d8e5 Compare July 2, 2026 22:05
@IlyaasK
IlyaasK merged commit fdd1ba5 into hypeship/v0-ci-correctness Jul 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants