Skip to content

Run acceptance tests after merges #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IlyaasK merged 3 commits into from
Jul 31, 2026
Merged

Run acceptance tests after merges #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63c1e23
Run acceptance tests on trusted pull requests
IlyaasK Jul 28, 2026
309779d
Run acceptance tests after merges
IlyaasK Jul 29, 2026
06dd269
Restack post-merge acceptance on current main
IlyaasK Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/acceptance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Acceptance

on:
push:
branches:
- main
workflow_dispatch:

permissions:
Expand Down
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ Do not run `terraform init` just to exercise this unreleased provider through `d

## Acceptance Tests

Acceptance tests are opt-in because they can create real Kernel resources.
Acceptance tests run automatically after changes reach `main` and can also be
started manually through the `Acceptance` workflow. Local runs remain opt-in
because they create real Kernel resources.

Required for all acceptance tests:

Expand Down
8 changes: 4 additions & 4 deletions docs/acceptance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Selected-Surface Acceptance Matrix

This document is the live-API release gate for the provider's selected public
surface. Unit tests remain the fast default. Acceptance tests run only through
explicit local opt-in or the manual GitHub Actions workflow.
surface. Unit tests remain the fast default. Acceptance tests run after changes
reach `main`, through explicit local opt-in, or by manual workflow dispatch.

The selected surface contains two managed resources and four read-only data
sources. It does not claim coverage for future or unregistered Kernel objects.
Expand Down Expand Up @@ -59,8 +59,8 @@ go test -count=1 -timeout=30m -v ./internal/datasources/proxy -run TestAcc
go test -count=1 -timeout=30m -v ./internal/datasources/extension -run TestAcc
```

The manual `Acceptance` workflow runs the same six packages as separate matrix
jobs with `fail-fast: false`. Live acceptance remains a manual pre-tag gate.
The `Acceptance` workflow runs the same six packages as separate matrix jobs
with `fail-fast: false` after changes reach `main` and on manual dispatch.

## Outside The Selected Surface

Expand Down
2 changes: 1 addition & 1 deletion docs/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Use this checklist before publishing a Kernel Terraform provider version.
checks each archive, and verifies checksum coverage. A snapshot skips signing
and is not a publishable release.
- Run the complete [selected-surface acceptance matrix](acceptance.md) with real credentials against the release commit.
- The manual `Acceptance` workflow runs all six packages as independent matrix jobs. Keep live tests out of normal pull-request CI.
- The `Acceptance` workflow runs all six packages as independent matrix jobs after changes reach `main` and supports manual dispatch. Keep live tests out of pull-request CI.
- Process-level timeouts can bypass Go test cleanup. After an interrupted or hard-timeout run:
1. In the Kernel dashboard or durable API, find projects, browser pools, profiles, proxies, and extensions named `kernel-tf-*` that were created during the failed workflow run.
2. Delete leaked browser pools with `force=false`. If deletion conflicts with a lease, wait for the lease to end; do not force-release or recover the browser from Terraform cleanup.
Expand Down