Add durable extension acceptance fixtures - #104
Merged
Conversation
IlyaasK
marked this pull request as ready for review
July 27, 2026 21:45
IlyaasK
force-pushed
the
hypeship/proxy-data-source-acceptance
branch
from
July 28, 2026 13:22
15f7e92 to
de4893d
Compare
IlyaasK
force-pushed
the
hypeship/extension-acceptance-fixture
branch
from
July 28, 2026 13:23
a06c10b to
08f1ba9
Compare
IlyaasK
force-pushed
the
hypeship/proxy-data-source-acceptance
branch
from
July 28, 2026 13:28
de4893d to
15f7e92
Compare
IlyaasK
force-pushed
the
hypeship/extension-acceptance-fixture
branch
from
July 28, 2026 13:28
08f1ba9 to
a06c10b
Compare
Sayan-
approved these changes
Jul 28, 2026
IlyaasK
force-pushed
the
hypeship/proxy-data-source-acceptance
branch
from
July 29, 2026 19:06
15f7e92 to
f41e8d5
Compare
IlyaasK
changed the base branch from
hypeship/proxy-data-source-acceptance
to
main
July 29, 2026 19:34
IlyaasK
force-pushed
the
hypeship/extension-acceptance-fixture
branch
from
July 29, 2026 19:36
a06c10b to
de11cd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this is v0 work
The existing
kernel_extensiondata source needs a real uploaded fixture for live acceptance coverage. These helpers create and clean up that durable fixture without adding the parked Terraform extension resource.Tests
go test -short -timeout=2m ./...go test -race -short -timeout=2m ./internal/kernelclient ./internal/acctestgo vet ./...go mod verifygo mod tidy -diffterraform fmt -check -recursive examplesbash scripts/check-markdown-links.shbash scripts/check-docs.shgit diff --checkgofmt -l cmd internalAcceptance status
No live API test is added in this fixture-only PR. The stacked extension data-source acceptance PR uploads the fixture and exercises cleanup.
Intentionally unsupported
Note
Low Risk
Changes are limited to acceptance helpers and a narrow client surface, following established proxy/profile cleanup patterns with no provider resource or auth changes.
Overview
Adds project-scoped extension upload and delete on the provider
kernelclient, using the same mutation rules as other resources (explicit project header, no SDK retries on writes).Adds
CleanupExtensioninacctestso acceptance tests can tear down uploaded extension fixtures: gated on acceptance env/API key, default project resolution, timed delete context, 404 treated as clean, and other delete errors surfaced.Tests cover cleanup behavior (including the new
extension_test.go) and fold upload/delete into the existing mutation-scope table; a reflect test asserts download / Chrome Store extension APIs stay offClients.Reviewed by Cursor Bugbot for commit de11cd5. Bugbot is set up for automated code reviews on this repo. Configure here.