Skip to content

Skip HTTP logs with unparseable timestamps instead of crashing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sayan- wants to merge 1 commit into from
Closed

Skip HTTP logs with unparseable timestamps instead of crashing #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions internal/railway/subscribe/http_logs/subscribe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,14 +253,12 @@ func getHttpLogs(ctx context.Context, g *railway.GraphQLClient, initialDeploymen
for i := range logs.Payload.Data.HTTPLogs {
logTimestamp, err := getTimeStampAttributeFromHttpLog(logs.Payload.Data.HTTPLogs[i])
if err != nil {
logger.Stdout.Error("failed to get timestamp from http log",
logger.Stdout.Error("failed to get timestamp from http log, skipping log",
slog.String("deployment_id", initialDeployment.ID.String()),
logger.ErrAttr(err),
)

// we return an error here because this isn't something we can recover from
// returning here will cause the goroutine to exit and the parent SubscribeToHttpLogs function to return the error
return fmt.Errorf("failed to get timestamp from http log: %w", err)
continue
}

if !logTimestamp.After(logTimes) || logTimestamp.Before(initTime) {
Expand Down
Loading