Skip to content

feat(browsers): add Pool column to browsers list #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masnwilliams wants to merge 5 commits into from
Closed

feat(browsers): add Pool column to browsers list #60

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7faef87
feat(browsers): add Pool column to browsers list
masnwilliams Jan 5, 2026
badd948
feat(browsers): log browser details in list output
masnwilliams Jan 5, 2026
bbc9b8a
Merge branch 'main' into mason/show-pool-id-in-browsers-list
masnwilliams Jan 12, 2026
ec73d9e
Merge branch 'main' into mason/show-pool-id-in-browsers-list
masnwilliams Jan 21, 2026
7ec1e4e
Remove logging of browsers in the List command of BrowsersCmd to stre…
masnwilliams Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmd/browsers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func (b BrowsersCmd) List(ctx context.Context, in BrowsersListInput) error {
}

// Prepare table data
headers := []string{"Browser ID", "Created At", "Persistent ID", "Profile", "CDP WS URL", "Live View URL"}
headers := []string{"Browser ID", "Created At", "Persistent ID", "Profile", "Pool", "CDP WS URL", "Live View URL"}
if in.IncludeDeleted {
headers = append(headers, "Deleted At")
}
Expand All @@ -262,11 +262,18 @@ func (b BrowsersCmd) List(ctx context.Context, in BrowsersListInput) error {
profile = browser.Profile.ID
}

// Check for pool_id in ExtraFields (until SDK is updated with PoolID field)
poolID := "-"
if pf, ok := browser.JSON.ExtraFields["pool_id"]; ok && pf.Valid() {
poolID = "Pooled"
}

row := []string{
browser.SessionID,
util.FormatLocal(browser.CreatedAt),
persistentID,
profile,
poolID,
truncateURL(browser.CdpWsURL, 50),
truncateURL(browser.BrowserLiveViewURL, 50),
}
Expand Down