allow different types of res_iter #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this is fully backwards compatible, right? Could you update the code so it merges cleanly? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently WSAPI accepts only
functioniterator asres_iter. This forces WSAPI frameworks and applications writers to returnfunctioniterator from theirrun(). Following code change allows users to use four different types of iterator:function,thread,table,string.There is also small change for strictier check of
not restotype(res) ~= "string", so for example if iterator returns some booleantrueor table, it will no go tolfcgi.write()raising error atluaL_checklstring(), because it is not WSAPI error, it is application's error, application should return only strings fromres_iter!