Allow slow update downloads#910
Merged
Merged
Conversation
roborev update used a 30 second http.Client timeout for both metadata checks and archive downloads. Go applies that timeout to the entire request, including streaming the response body, so slow but healthy release downloads could fail midway with context deadline exceeded. Keep metadata discovery bounded with explicit contexts and response-header timeouts, but avoid a whole-request client timeout for archive body reads. Install still has a much longer deadline so stuck downloads do not run forever. Fixes #895 Generated with Codex Co-authored-by: Codex <codex@openai.com>
roborev: Combined Review (
|
Technophobe01
added a commit
to Technophobe01/roborev
that referenced
this pull request
Jun 28, 2026
…ker-image * upstream/main: Allow slow update downloads (kenn-io#910) Document [analyze.<type>] config for fieldless review types (kenn-io#909) Add lookahead review type for time-series bias (kenn-io#904) Support per-analysis agent config (kenn-io#902) Update flake.nix for v0.60.0 (kenn-io#900) Document 0.60.0 release (kenn-io#901) Reject dirty submodule edits during refine (kenn-io#896) Revamp onboarding: quickstart command, automation-first docs (kenn-io#899) Add Codex config passthrough for -c overrides (kenn-io#897) Prefer managed roborev shims in hook installs (kenn-io#898) Update flake.nix for v0.59.2 (kenn-io#893) Document 0.59.2 release (kenn-io#894) Open Homebrew tap updates through PRs (kenn-io#885) Parse Copilot JSON review output (kenn-io#892) Stabilize analyze agent invocation (kenn-io#889) Require explicit workflow backup agents (kenn-io#887) Include analyze jobs in fix discovery (kenn-io#890)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roborev update used a 30 second http.Client timeout for both metadata checks and archive downloads. Go applies that timeout to the whole request, including streaming the response body, so slow but healthy release downloads could fail midway with context deadline exceeded.
This keeps update metadata discovery bounded while avoiding a whole-request client timeout for archive body reads. Installs still use a longer deadline so stuck downloads do not run indefinitely.
Closes #895