Plan ACP agent chat integration#241
Draft
mariusvniekerk wants to merge 8 commits into
Draft
Conversation
mariusvniekerk
commented
May 3, 2026
mariusvniekerk
commented
Collaborator
- Add an ACP-backed chat design for workspace sessions with detachable ambient-sidebar boundaries
- Define protocol lifecycle, server APIs, persistence, permissions, and safety rules
- Capture composer autocomplete, process indicators, tool-call grouping, and GFM chat rendering
roborev: Combined Review (
|
roborev: Combined Review (
|
roborev: Combined Review (
|
Document the ACP-backed chat architecture for workspace sessions, including the detachable frontend boundary needed for future ambient sidebar use. Capture protocol lifecycle, API shape, storage, permissions, and testing scope before implementation planning.
Tighten the ACP chat design before implementation by adding acceptance criteria, server-owned workspace cwd validation, a normalized event contract, staged rollout tasks, API generation expectations, and resource/redaction constraints.
Capture composer support for @ file mentions and / skill suggestions in the ACP chat design, including scoped suggestion APIs, prompt conversion behavior, rollout slices, and tests.
Update the ACP chat design so session/update plan entries become durable process indicators with normalized task status, aggregate progress, UI surfaces, rollout steps, and tests.
Document collapsed grouping for successive ACP tool calls, including individual persistence, first-two/last-two default rendering, expansion behavior, aggregate status, and tests.
Document sanitized GitHub Flavored Markdown rendering for ACP chat messages, including table support, overflow behavior, structured event separation, and frontend tests.
ACP has added stable session lifecycle, metadata, command, and config-option surfaces since this design was written. The plan now accounts for session list/resume/close/delete capabilities, session_info_update, available_commands_update, config_option_update, and current tool-call patch semantics so future implementation slices do not bake in stale protocol assumptions. The tool-call section also calls out the ACP v2 draft direction as compatibility guidance because agents may already send update-only tool-call streams. Validation: git diff --check Generated with Codex Co-authored-by: Codex <codex@openai.com>
mariusvniekerk
force-pushed
the
acp-agent-chat-design
branch
from
91a341a to
0feaa58
Compare
roborev: Combined Review (
|
The previous spec refresh relied on the published ACP docs but did not exercise the installed codex-acp adapter. Local validation against codex-acp 0.16.0 showed that initialize advertises loadSession, session list/resume/close, prompt, MCP, and auth capabilities, while session configuration arrives from session/new rather than an initialize capability. The transport guidance now preserves ACP newline-delimited writes while requiring the reader to tolerate complete JSON responses that are not newline-terminated, which matches the observed codex-acp initialize response. Validation: codex-acp initialize, session/new, session/close, and session/list smoke tests; git diff --check Generated with Codex Co-authored-by: Codex <codex@openai.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.