verify.yml: drop the double-build (install-only) for gh#95#150
Merged
Conversation
Verify never publishes an archive, so drop the extra `gale build` and do the single build via `gale install`, halving heavy-recipe verify time (gh#95). check_install.py scans the installed store prefix instead of an extracted archive; same files, same baked rpaths. The restore-only dep cache repopulates ~/.gale/pkg, and the installer returns MethodCached (no build) when the target already exists (no `gale install --force` exists). Evict ~/.gale/pkg/<recipe> before installing so verify always exercises a real build and the runner-override re-verify path still rebuilds; deps stay cached, preserving the speedup. Closes #95 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USxMtcZRitDUGBEnBZ3inn
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USxMtcZRitDUGBEnBZ3inn
f7fdce4 to
bba2cff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify.ymlused togale builda changed recipe (for thetar.zst + sha256) and then
gale install --recipeit (topopulate the dependency farm). Since sccache is intentionally
off in verify (supply-chain hardening), that second full
compile roughly doubled heavy-recipe verify wall time. Verify
never publishes an archive, so it does not need
gale buildatall.
Changes
.github/workflows/verify.ymlgale install --global <recipe> --recipe <file>(one build,populates the farm, lands the binary at its real store path).
--prefix/--archive); same files, same baked rpaths as thearchive, so the check is equivalent.
step (
rm -rf "$HOME/.gale/pkg/${RECIPE_NAME}") before theinstall. The restore-only
deps-<platform>-cacherepopulates
~/.gale/pkgwith any previously built revisionof the target, and gale's installer returns MethodCached
(no build) when the store path already exists
(
gale install --recipehas no--force). Without evictionthe install-only flow would compile nothing and the checks
would validate a stale cached binary. Deps stay cached,
preserving the speedup.
build-chunk.ymlkeeps both steps(its archive/sha256 feed the GHCR push).
scripts/check_install.py--prefixnor--archiveis given, resolve~/.gale/pkg/<name>/<version>-<revision>from the recipe(matching
verify_binary.py/run_smoke.py) and fail loudlyif that prefix is absent.
Test notes
scripts/test_issue95_store_prefix.py:resolve_prefixrevision-suffix behavior, default-prefix CLI(scans installed store; missing prefix exits 1), and two
workflow-structure tests asserting verify.yml evicts the target
store before the build/checks. The eviction tests fail on the
pre-fix tree and pass after. Full suite: 202 passing.
actionlintclean on the changed verify.yml; shellcheck cleanon the new step.
Closes #95
🤖 Generated with Claude Code
https://claude.ai/code/session_01USxMtcZRitDUGBEnBZ3inn
Note
Medium Risk
Changes the merge-gate verify path (build vs cache semantics); incorrect eviction or default prefix logic could let stale binaries pass or break rpath checks, though new workflow and CLI tests mitigate that.
Overview
Verify CI no longer runs
gale buildplus a secondgale install --recipe. It does onegale install --global(with retries), which is enough because verify never publishes archives—build-chunk.ymlstill uses build+install for GHCR.Before install, verify
rm -rf ~/.gale/pkg/${RECIPE_NAME}so a restored dep cache cannot make the installer skip the target recipe with MethodCached; dependency caches stay, so heavy recipes still get the intended speedup while every run compiles the recipe under test.check_install.pycan omit--prefix/--archive: it resolves~/.gale/pkg/<name>/<version>-<revision>from the recipe (aligned withverify_binary.py) and exits with an error if that prefix is missing. Verify’s rpath step calls it that way instead of extracting the build archive.scripts/test_issue95_store_prefix.pycovers default prefix resolution, missing-prefix failure, and that eviction runs before install and checks. CHANGELOG records the behavior change.Reviewed by Cursor Bugbot for commit bba2cff. Bugbot is set up for automated code reviews on this repo. Configure here.