Skip to content

Fix identifying nested reference placeholders - #13688

Merged
droidmonkey merged 2 commits into
developfrom
fix/identify_nested_reference_placeholders
Sep 19, 2026
Merged

droidmonkey merged 2 commits into
developfrom
fix/identify_nested_reference_placeholders

Conversation

@varjolintu

@varjolintu varjolintu commented Sep 18, 2026

Copy link
Copy Markdown
Member

Deeply nested reference placeholders were not properly detected. Those must not be bound to the ResolveMaximumDepth.

Moved matchReference() to EntryPlaceholders class, and used that to check for nested reference placeholders if the placeholder type was not known.

Testing strategy

Automatic tests added.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@varjolintu varjolintu added this to the v2.8.0 milestone Sep 18, 2026
@varjolintu
varjolintu requested a review from a team September 18, 2026 05:59
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.13%. Comparing base (5ac1b0c) to head (a9c3b7e).

Files with missing lines Patch % Lines
src/core/Entry.cpp 66.67% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #13688   +/-   ##
========================================
  Coverage    63.13%   63.13%           
========================================
  Files          388      388           
  Lines        41129    41131    +2     
========================================
+ Hits         25964    25966    +2     
  Misses       15165    15165           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@droidmonkey
droidmonkey merged commit 474da9b into develop Sep 19, 2026
12 checks passed
@droidmonkey
droidmonkey deleted the fix/identify_nested_reference_placeholders branch September 19, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants