SSH Agent: Add support for ML-DSA 44 + Ed25519 keys#13522
Draft
hifi wants to merge 1 commit into
Draft
Conversation
hifi
added
feature: SSH agent
pr: ai-assisted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13507
I have not actually tested this properly yet, just pushing the PR out. The generation bit looks sketchy but it passes its own tests and is 100% LLM written.
This also depends on OpenSSH 10.4 so the tests will likely fail on our CI for now: https://www.openssh.org/txt/release-10.4
Screenshots
Testing strategy
Added tests plus tested by hand that ssh-agent accepts the keys and they indeed have the correct fingerprint. No full end-to-end testing yet.
Type of change