Fix directory creation error handling#13508
Merged
droidmonkey merged 1 commit intoJul 8, 2026
Merged
Conversation
When a directory is created successfully for saving attachments, do not error. Resolves keepassxreboot#13504.
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect error handling when creating the target directory for saving entry attachments in the GUI. This aligns with the reported behavior in #13504 by ensuring a successful QDir::mkpath() call does not incorrectly trigger an error.
Changes:
- Corrects the
QDir::mkpath()return-value check so errors are only raised when directory creation fails.
droidmonkey
approved these changes
Jul 8, 2026
Member
|
Oooh logic error, geez good find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a directory is created successfully for saving attachments, do not error.
Fixes (or is at least related to) #13504.
Simply corrects the sense of the QT mkpath return value check
Testing strategy
None, trivial fix.
Type of change