Use native user temporary directory path for the browser socket in macOS#13484
Open
varjolintu wants to merge 1 commit into
Open
Use native user temporary directory path for the browser socket in macOS#13484varjolintu wants to merge 1 commit into
varjolintu wants to merge 1 commit into
Conversation
varjolintu
added
platform: macOS
feature: Browser
pr: bugfix
varjolintu
marked this pull request as draft
July 1, 2026 15:04
varjolintu
force-pushed
the
fix/macos_native_tmp_dir
branch
from
July 3, 2026 16:04
6b9cc9e to
b567621
Compare
varjolintu
force-pushed
the
fix/macos_native_tmp_dir
branch
from
July 3, 2026 16:05
b567621 to
ebd3c9f
Compare
varjolintu
marked this pull request as ready for review
July 3, 2026 17:26
sameerbajaj
added a commit
to sameerbajaj/keepassxc
that referenced
this pull request
Jul 15, 2026
…th for the browser socket in macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In macOS for example Homebrew can override the user's temporary directory using the
$TMPDIRenvironment variable. Qt's internal functions will resolve that path instead of the one we actually want to create the socket for browser integration.Added a new function to BrowserShared that returns the native temporary directory from
_CS_DARWIN_USER_TEMP_DIRdirectly. It will always return the randomly generated temporary directory under/var/.Testing strategy
For debugging, you can start e.g. CLion with:
env TMPDIR=/private/tmp /Applications/CLion.app/Contents/MacOS/clionand see that that Qt's own function will respect the$TMPDIRenvironment variable. The new implementation still returns the correct path.Type of change